[ https://issues.apache.org/jira/browse/HBASE-21392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16702679#comment-16702679 ]
Hadoop QA commented on HBASE-21392: ----------------------------------- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 23s{color} | {color:blue} Docker mode activated. {color} | || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m 0s{color} | {color:green} Patch does not have any anti-patterns. {color} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | | {color:orange}-0{color} | {color:orange} test4tests {color} | {color:orange} 0m 0s{color} | {color:orange} The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m 33s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 43s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 29s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m 2s{color} | {color:green} branch has no errors when building our shaded downstream artifacts. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m 57s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 18s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m 50s{color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} compile {color} | {color:red} 0m 25s{color} | {color:red} hbase-client in the patch failed. {color} | | {color:red}-1{color} | {color:red} javac {color} | {color:red} 0m 25s{color} | {color:red} hbase-client in the patch failed. {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 28s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 3m 42s{color} | {color:green} patch has no errors when building our shaded downstream artifacts. {color} | | {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 8m 25s{color} | {color:green} Patch does not cause any errors with Hadoop 2.7.4 or 3.0.0. {color} | | {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 1m 5s{color} | {color:red} hbase-client generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 19s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} unit {color} | {color:green} 3m 8s{color} | {color:green} hbase-client in the patch passed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 14s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 34m 25s{color} | {color:black} {color} | \\ \\ || Reason || Tests || | FindBugs | module:hbase-client | | | Invocation of toString on org.apache.hadoop.hbase.TableName.getName() in org.apache.hadoop.hbase.client.HTable.checkClose() At HTable.java:in org.apache.hadoop.hbase.client.HTable.checkClose() At HTable.java:[line 1146] | \\ \\ || Subsystem || Report/Notes || | Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:b002b0b | | JIRA Issue | HBASE-21392 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12949928/HBase-21392_v1.patch | | Optional Tests | dupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 9116b23a306f 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh | | git revision | master / d6e1d18be9 | | maven | version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z) | | Default Java | 1.8.0_181 | | findbugs | v3.1.0-RC3 | | compile | https://builds.apache.org/job/PreCommit-HBASE-Build/15142/artifact/patchprocess/patch-compile-hbase-client.txt | | javac | https://builds.apache.org/job/PreCommit-HBASE-Build/15142/artifact/patchprocess/patch-compile-hbase-client.txt | | findbugs | https://builds.apache.org/job/PreCommit-HBASE-Build/15142/artifact/patchprocess/new-findbugs-hbase-client.html | | Test Results | https://builds.apache.org/job/PreCommit-HBASE-Build/15142/testReport/ | | Max. process+thread count | 288 (vs. ulimit of 10000) | | modules | C: hbase-client U: hbase-client | | Console output | https://builds.apache.org/job/PreCommit-HBASE-Build/15142/console | | Powered by | Apache Yetus 0.8.0 http://yetus.apache.org | This message was automatically generated. > HTable can still write data after calling the close method. > ----------------------------------------------------------- > > Key: HBASE-21392 > URL: https://issues.apache.org/jira/browse/HBASE-21392 > Project: HBase > Issue Type: Improvement > Components: Client > Affects Versions: 1.2.0, 2.1.0, 2.0.0 > Environment: HBase 1.2.0 > Reporter: lixiaobao > Assignee: lixiaobao > Priority: Major > Attachments: HBase-21392_v1.patch > > Original Estimate: 1h > Remaining Estimate: 1h > > HTable can still write data after calling the close method. > > {code:java} > val conn = ConnectionFactory.createConnection(conf) > var table = conn.getTable(TableName.valueOf(tableName)) > val put = new Put(rowKey.getBytes()) > put.addColumn("cf".getBytes(), columnField.getBytes(), endTimeLong, > Bytes.toBytes(line.getLong(8))) > table.put(put) > //call table close() method > table.close() > //put again > val put1 = new Put(rowKey4.getBytes()) > out1.addColumn("cf".getBytes(), columnField.getBytes(), endTimeLong, > Bytes.toBytes(line.getLong(8))) > table.put(put1) > {code} > > after call close method ,can alse write data into HBase,I think this does not > match close logic. -- This message was sent by Atlassian JIRA (v7.6.3#76005)