[
https://issues.apache.org/jira/browse/HBASE-5533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13226238#comment-13226238
]
stack commented on HBASE-5533:
------------------------------
Line lengths are usually < 80 chars in our src code Shaneal.
Minor, assign and declare on the one line the below rather than wait till
constructor?
{code}
+ this.counts = new MapMaker().makeComputingMap(new Function<String,
Counter>() {
+ @Override
+ public Counter apply(String input) {
+ return new Counter();
+ }
+ });
{code}
This looks cool... ExponentiallyDecayingSample
Snapshot looks excellent.
UniformSample looks sweet
On this...
{code}
+ final long startTime = System.nanoTime();
{code}
... aren't we getting a currentTimeMillis soon after? Do we want to be doing
all this time getting? We should minimize as much as we can? Check it out I'd
say. Also, there is EdgeEnvironment or EnvironmentEdge that we use for system
things like getting time because we want to have a layer between us and system
especially when testing ... so we can mess things up. You might want to check
it out.
Tests look good.
How does this stuff look for a server under load? Will say tsdb be able to
make sense of it? Hows it look in the ui? I suppose I could just apply the
patch and try it but you might have some pictures laying around.
How did we make it this far w/o this stuff?
> Add more metrics to HBase
> -------------------------
>
> Key: HBASE-5533
> URL: https://issues.apache.org/jira/browse/HBASE-5533
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.92.0
> Reporter: Shaneal Manek
> Assignee: Shaneal Manek
> Priority: Minor
> Attachments: BlockingQueueContention.java, hbase-5533-0.92.patch,
> hbase5533-0.92-v2.patch, hbase5533-0.92-v3.patch
>
>
> To debub/monitor production clusters, there are some more metrics I wish I
> had available.
> In particular:
> - Although the average FS latencies are useful, a 'histogram' of recent
> latencies (90% of reads completed in under 100ms, 99% in under 200ms, etc)
> would be more useful
> - Similar histograms of latencies on common operations (GET, PUT, DELETE)
> would be useful
> - Counting the number of accesses to each region to detect hotspotting
> - Exposing the current number of HLog files
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
