[ https://issues.apache.org/jira/browse/HBASE-18830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16720747#comment-16720747 ]
Hudson commented on HBASE-18830: -------------------------------- SUCCESS: Integrated in Jenkins build HBase-1.3-IT #509 (See [https://builds.apache.org/job/HBase-1.3-IT/509/]) Amend HBASE-18830 TestCanaryTool does not check Canary monitor's error (apurtell: rev 5d0d3aa2b962a27a7eb33b20ef91476893380b89) * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/tool/Canary.java > TestCanaryTool does not check Canary monitor's error code > --------------------------------------------------------- > > Key: HBASE-18830 > URL: https://issues.apache.org/jira/browse/HBASE-18830 > Project: HBase > Issue Type: Bug > Reporter: Chinmay Kulkarni > Assignee: Chinmay Kulkarni > Priority: Major > Fix For: 1.4.0, 1.3.3, 2.0.0 > > Attachments: HBASE-18830.001.patch > > > None of the tests inside TestCanaryTool check Canary monitor's error code. > Thus, it is possible that the monitor has registered an error and yet the > tests pass. We should check the value returned by the _ToolRunner.run()_ > method inside each unit test. -- This message was sent by Atlassian JIRA (v7.6.3#76005)