[ 
https://issues.apache.org/jira/browse/HBASE-20984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16721966#comment-16721966
 ] 

Sakthi commented on HBASE-20984:
--------------------------------

Hi [~busbey], I have removed the unneeded line in TestWALFactory and have 
modified TestWALRootDir to test custom WALs in multiple filesystems(hdfs & 
local). Also have utilized the existing temp folder creation utilities to get 
one for local as well.

I did verify that local WALs were being created by the test.

> Add/Modify test case to check custom hbase.wal.dir outside hdfs filesystem
> --------------------------------------------------------------------------
>
>                 Key: HBASE-20984
>                 URL: https://issues.apache.org/jira/browse/HBASE-20984
>             Project: HBase
>          Issue Type: Bug
>          Components: test, wal
>            Reporter: Sakthi
>            Assignee: Sakthi
>            Priority: Minor
>         Attachments: hbase-20984.master.001.patch
>
>
> The current setup in TestWALFactory tries to create custom WAL directory 
> outside hdfs but ends up creating a custom WAL directory inside hdfs. In 
> TestWALFactory.java:
> {code:java}
> public static void setUpBeforeClass() throws Exception {
>     CommonFSUtils.setWALRootDir(TEST_UTIL.getConfiguration(), new 
> Path("file:///tmp/wal")); // A local filesystem WAL is attempted
> ...
>     hbaseDir = TEST_UTIL.createRootDir();
>     hbaseWALDir = TEST_UTIL.createWALRootDir(); // But a directory inside 
> hdfs is created here using HBaseTestingUtility#getNewDataTestDirOnTestFS
> }
> {code}
> The change was made in HBASE-20723



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to