[ https://issues.apache.org/jira/browse/HBASE-21020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16725574#comment-16725574 ]
Hadoop QA commented on HBASE-21020: ----------------------------------- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 20s{color} | {color:blue} Docker mode activated. {color} | || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m 0s{color} | {color:green} Patch does not have any anti-patterns. {color} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | | {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s{color} | {color:green} The patch appears to include 5 new or modified test files. {color} | || || || || {color:brown} HBASE-20952 Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 1m 28s{color} | {color:blue} Maven dependency ordering for branch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m 30s{color} | {color:green} HBASE-20952 passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 5m 13s{color} | {color:green} HBASE-20952 passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 2m 10s{color} | {color:green} HBASE-20952 passed {color} | | {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 3m 49s{color} | {color:green} branch has no errors when building our shaded downstream artifacts. {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 0s{color} | {color:blue} Skipped patched modules with no Java source: . {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 1m 57s{color} | {color:blue} hbase-server in HBASE-20952 has 1 extant Findbugs warnings. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 3m 22s{color} | {color:green} HBASE-20952 passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 14s{color} | {color:blue} Maven dependency ordering for patch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m 0s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 5m 12s{color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} javac {color} | {color:red} 5m 12s{color} | {color:red} root generated 1 new + 1148 unchanged - 1 fixed = 1149 total (was 1149) {color} | | {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 2m 3s{color} | {color:red} root: The patch generated 6 new + 191 unchanged - 13 fixed = 197 total (was 204) {color} | | {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m 0s{color} | {color:red} The patch has 8 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply {color} | | {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m 1s{color} | {color:green} The patch has no ill-formed XML file. {color} | | {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 3m 50s{color} | {color:green} patch has no errors when building our shaded downstream artifacts. {color} | | {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 8m 21s{color} | {color:green} Patch does not cause any errors with Hadoop 2.7.4 or 3.0.0. {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 0s{color} | {color:blue} Skipped patched modules with no Java source: . {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m 44s{color} | {color:green} hbase-common in the patch passed. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m 9s{color} | {color:green} hbase-server generated 0 new + 0 unchanged - 1 fixed = 0 total (was 1) {color} | | {color:red}-1{color} | {color:red} javadoc {color} | {color:red} 0m 30s{color} | {color:red} hbase-server generated 10 new + 2 unchanged - 0 fixed = 12 total (was 2) {color} | | {color:red}-1{color} | {color:red} javadoc {color} | {color:red} 2m 30s{color} | {color:red} root generated 10 new + 6 unchanged - 0 fixed = 16 total (was 6) {color} | || || || || {color:brown} Other Tests {color} || | {color:red}-1{color} | {color:red} unit {color} | {color:red}239m 14s{color} | {color:red} root in the patch failed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 1m 3s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black}295m 42s{color} | {color:black} {color} | \\ \\ || Reason || Tests || | Failed junit tests | hadoop.hbase.wal.TestWALFactory | | | hadoop.hbase.client.TestAsyncTable | | | hadoop.hbase.replication.regionserver.TestWALEntryStream | | | hadoop.hbase.TestClientOperationTimeout | | | hadoop.hbase.client.TestAdmin1 | \\ \\ || Subsystem || Report/Notes || | Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:b002b0b | | JIRA Issue | HBASE-21020 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12952426/HBASE-21020.HBASE-20952.004.patch | | Optional Tests | dupname asflicense xml javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 309b07e4f470 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh | | git revision | HBASE-20952 / c738e1575f | | maven | version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z) | | Default Java | 1.8.0_181 | | findbugs | v3.1.0-RC3 | | javac | https://builds.apache.org/job/PreCommit-HBASE-Build/15333/artifact/patchprocess/diff-compile-javac-root.txt | | checkstyle | https://builds.apache.org/job/PreCommit-HBASE-Build/15333/artifact/patchprocess/diff-checkstyle-root.txt | | whitespace | https://builds.apache.org/job/PreCommit-HBASE-Build/15333/artifact/patchprocess/whitespace-eol.txt | | javadoc | https://builds.apache.org/job/PreCommit-HBASE-Build/15333/artifact/patchprocess/diff-javadoc-javadoc-hbase-server.txt | | javadoc | https://builds.apache.org/job/PreCommit-HBASE-Build/15333/artifact/patchprocess/diff-javadoc-javadoc-root.txt | | unit | https://builds.apache.org/job/PreCommit-HBASE-Build/15333/artifact/patchprocess/patch-unit-root.txt | | Test Results | https://builds.apache.org/job/PreCommit-HBASE-Build/15333/testReport/ | | Max. process+thread count | 4888 (vs. ulimit of 10000) | | modules | C: hbase-common hbase-server . U: . | | Console output | https://builds.apache.org/job/PreCommit-HBASE-Build/15333/console | | Powered by | Apache Yetus 0.8.0 http://yetus.apache.org | This message was automatically generated. > Determine WAL API changes for replication > ----------------------------------------- > > Key: HBASE-21020 > URL: https://issues.apache.org/jira/browse/HBASE-21020 > Project: HBase > Issue Type: Sub-task > Components: wal > Reporter: Josh Elser > Assignee: Ankit Singhal > Priority: Major > Fix For: HBASE-20952 > > Attachments: HBASE-21020.HBASE-20952.001.patch, > HBASE-21020.HBASE-20952.002.patch, HBASE-21020.HBASE-20952.003.patch, > HBASE-21020.HBASE-20952.004.patch > > > Spin-off of HBASE-20952. > Ankit has started working on what he thinks a WAL API specifically for > Replication should look like. In his own words: > {quote} > At a high level, it looks, > * Need to abstract WAL name under WalInfo instead of Paths > * Abstract the WalEntryStream for FileSystem and Streaming system. > * Build WalStorage APIs to abstract operation on Wal. > * Provide the implementation of all above through corresponding WalProvider > {quote} -- This message was sent by Atlassian JIRA (v7.6.3#76005)