[
https://issues.apache.org/jira/browse/HBASE-21628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16727547#comment-16727547
]
stack commented on HBASE-21628:
-------------------------------
Looks good. Want to say in one line how you've changed the behavior here...
swapping in a new executorservice in place of custom thread launch and why your
approach? Thanks.
BLOCKER is used in one place only. Why the static define? s/block/blocked/ It
is to block on?
Please follow the style of the files you are changing (Notice how spaces before
open of parens?)
Give below a bit of an edit please? We throw DifferentScanThreadException if
two threads share a prefetcher?
24 * Throw when different thread scan result use same
25 * {@link org.apache.hadoop.hbase.client.ClientAsyncPrefetchScanner}
Thanks.
> memory leak risk when ClientAsyncPrefetchScanner not close
> ----------------------------------------------------------
>
> Key: HBASE-21628
> URL: https://issues.apache.org/jira/browse/HBASE-21628
> Project: HBase
> Issue Type: Improvement
> Reporter: cong.han
> Assignee: cong.han
> Priority: Major
> Attachments: HBASE-21328-v1.patch, HBASE-21628-v2.patch
>
>
> When we use ClientAsyncPrefetchScanner and we do two things below
> 1 Forgot to call close() method
> 2 The result are not full fetched
> The prefetch thread will not exit and leave a memory leak risk.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
