[ 
https://issues.apache.org/jira/browse/HBASE-21649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16729680#comment-16729680
 ] 

Sean Busbey commented on HBASE-21649:
-------------------------------------

That argument totally makes sense to me, but this is a significant enough 
change to warrant a DISCUSS thread. Not everyone who uses thrift1 will agree.

You also currently have targeted the next minor release of 2.y for this change, 
which some folks might take issue with.

The goal of a scope document is to make sure we have a consensus on what the 
acceptable state of "done" is for this to be in release lines. Impact on 
upgrades is of particular concern to me, for example.

> Complete Thrift2 to supersede Thrift1
> -------------------------------------
>
>                 Key: HBASE-21649
>                 URL: https://issues.apache.org/jira/browse/HBASE-21649
>             Project: HBase
>          Issue Type: Umbrella
>            Reporter: Allan Yang
>            Assignee: Allan Yang
>            Priority: Major
>             Fix For: 3.0.0, 2.2.0
>
>
> Thrift1 and Thrift2 coexists in our project for a very long time. 
> Functionality is more complete in thrift1 but its interface design is bad for 
> adding new features(so we have get(), getVer(),getVerTs,getRowWithColumns() 
> and so many other methods for a single get request, this is bad). Thrift2 has 
> a more clean interface and structure definition, making our user more easy to 
> use. But, it has not been updated for a long time, lacking of DDL method is a 
> major weakness. 
> I think we should complete Thrift2 and supersede Thrift1, making Thrift2 as 
> the standard multi language definition. This is a umbrella issue to make it 
> happen. 
> The plan would be:
> 1. Complete the DDL interface of thrift2
> 2. Making thrift2 server be able to handle thrift1 requests, user don't have 
> to choose which thrift server they need to start
> 3. Deprecate thrift1



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to