[
https://issues.apache.org/jira/browse/HBASE-5206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13227661#comment-13227661
]
Ted Yu commented on HBASE-5206:
-------------------------------
Patch v2 looks good.
Minor comments:
{code}
// Call to undisableTable does this. TODO: Make a more formal purge table.
- am.getZKTable().setEnabledTable(Bytes.toString(tableName));
+ am.getZKTable().setDeletedTable(Bytes.toString(tableName));
{code}
I don't see undisableTable. Can we remove the comment above ?
{code}
+ } else if (!this.zkTable
+ .isEnabledTable(region.getTableNameAsString())) {
+ setEnabledTable(region);
{code}
setEnabledTable(HRegionInfo hri) already calls zkTable.isEnabledTable(). It
seems we can call setEnabledTable(region) directly above.
> Port HBASE-5155 to 0.92 and TRUNK
> ---------------------------------
>
> Key: HBASE-5206
> URL: https://issues.apache.org/jira/browse/HBASE-5206
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.92.2, 0.96.0
> Reporter: Zhihong Yu
> Attachments: 5206_92_1.patch, 5206_92_latest_1.patch,
> 5206_trunk_1.patch, 5206_trunk_latest_1.patch
>
>
> This JIRA ports HBASE-5155 (ServerShutDownHandler And Disable/Delete should
> not happen parallely leading to recreation of regions that were deleted) to
> 0.92 and TRUNK
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
