[ 
https://issues.apache.org/jira/browse/HBASE-21652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16730611#comment-16730611
 ] 

Allan Yang commented on HBASE-21652:
------------------------------------

Major Changes made in the patch:
- HBaseHandler is extracted from ThriftServerRunner and renamed as 
ThriftHBaseServiceHandler
- ImplType is extracted from ThriftServerRunner as a independent class
- Configs are now all in class Constants
- Adding a abstract class HBaseServiceHandler, making thrift1 and thrift2's 
ThriftHBaseServiceHandler are inherited from it
- ThriftServerRunner is removed and merged into class ThriftServer.
- Thrift2 Server is now inherited from Thrift1 server.

> Refactor ThriftServer making thrift2 server inherited from thrift1 server
> -------------------------------------------------------------------------
>
>                 Key: HBASE-21652
>                 URL: https://issues.apache.org/jira/browse/HBASE-21652
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Allan Yang
>            Assignee: Allan Yang
>            Priority: Major
>
> Except the different protocol, thrift2 Server should have no much difference 
> from thrift1 Server.  So refactoring the thrift server, making thrift2 server 
> inherit from thrift1 server. Getting rid of many duplicated code.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to