[
https://issues.apache.org/jira/browse/HBASE-4608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13227898#comment-13227898
]
stack commented on HBASE-4608:
------------------------------
In TestLRUDictionary, we test a single entry in essence. We should try it w/
all kinds of rubbish... really long entries, empty entries, null entries....
similar entries... a dictionary for 32k worth of stuff..as we'll do in the
wild. So I'd think?
A test for the new class KeyValueCompression would be good to have too.
enableCompression is an odd name for this method. Should it be
setCompressionContext since that is what it does (you pass null if no
compression)... seems odd passing null to 'enableCompression'
Should the Compression class in wal package have more javadoc comments
explaining the kinda of compression it does? Otherwise, it looks like a
generic compressor class when in facts its a one-trick pony?
Should this method, WALCompressionEnabled, be isWALCompressionEnabled?
I like your idea of versioning the WAL
Patch is coming along nicely. Almost there.
> HLog Compression
> ----------------
>
> Key: HBASE-4608
> URL: https://issues.apache.org/jira/browse/HBASE-4608
> Project: HBase
> Issue Type: New Feature
> Reporter: Li Pi
> Assignee: Li Pi
> Fix For: 0.94.0
>
> Attachments: 4608-v19.txt, 4608-v20.txt, 4608-v22.txt, 4608v1.txt,
> 4608v13.txt, 4608v13.txt, 4608v14.txt, 4608v15.txt, 4608v16.txt, 4608v17.txt,
> 4608v18.txt, 4608v5.txt, 4608v6.txt, 4608v7.txt, 4608v8fixed.txt
>
>
> The current bottleneck to HBase write speed is replicating the WAL appends
> across different datanodes. We can speed up this process by compressing the
> HLog. Current plan involves using a dictionary to compress table name, region
> id, cf name, and possibly other bits of repeated data. Also, HLog format may
> be changed in other ways to produce a smaller HLog.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
