[ https://issues.apache.org/jira/browse/HBASE-21740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16746069#comment-16746069 ]
lujie edited comment on HBASE-21740 at 1/18/19 9:31 AM: -------------------------------------------------------- shutdown before startServices: {code:java} if (!isStopped() && !isAborted()) { initializeThreads(); }{code} so initializeThreads will skip and cacheFlusher is null cacheFlusher will use in line 1978, hence NPE happens Give the simple fix! was (Author: xiaoheipangzi): Give the simple fix! > NPE happens while shutdown the RS > --------------------------------- > > Key: HBASE-21740 > URL: https://issues.apache.org/jira/browse/HBASE-21740 > Project: HBase > Issue Type: Bug > Reporter: lujie > Assignee: lujie > Priority: Major > Attachments: HBASE-21740_1.patch > > > while shutdown a NM, we meet the NPE: > {code:java} > 2019-01-18 16:52:05,500 INFO [Thread-4] regionserver.HRegionServer: STOPPED: > Shutdown hook > 2019-01-18 16:52:05,896 INFO [regionserver/hadoop15:16020] > regionserver.MetricsRegionServerWrapperImpl: Computing regionserver metrics > every 5000 milliseconds > 2019-01-18 16:52:05,978 INFO [regionserver/hadoop15:16020.Chore.1] > hbase.ScheduledChore: Chore: CompactedHFilesCleaner was stopped > 2019-01-18 16:52:05,996 ERROR [regionserver/hadoop15:16020] > regionserver.HRegionServer: Failed init > java.lang.NullPointerException > at > org.apache.hadoop.hbase.regionserver.HRegionServer.startServices(HRegionServer.java:1978) > at > org.apache.hadoop.hbase.regionserver.HRegionServer.handleReportForDutyResponse(HRegionServer.java:1572) > at > org.apache.hadoop.hbase.regionserver.HRegionServer.run(HRegionServer.java:975) > at java.lang.Thread.run(Thread.java:745) > 2019-01-18 16:52:06,011 ERROR [regionserver/hadoop15:16020] > regionserver.HRegionServer: ***** ABORTING region server > hadoop15,16020,1547801516426: Unhandled: Region server startup failed ***** > java.io.IOException: Region server startup failed > at > org.apache.hadoop.hbase.regionserver.HRegionServer.convertThrowableToIOE(HRegionServer.java:3392) > at > org.apache.hadoop.hbase.regionserver.HRegionServer.handleReportForDutyResponse(HRegionServer.java:1591) > at > org.apache.hadoop.hbase.regionserver.HRegionServer.run(HRegionServer.java:975) > at java.lang.Thread.run(Thread.java:745) > Caused by: java.lang.NullPointerException > at > org.apache.hadoop.hbase.regionserver.HRegionServer.startServices(HRegionServer.java:1978) > at > org.apache.hadoop.hbase.regionserver.HRegionServer.handleReportForDutyResponse(HRegionServer.java:1572) > ... 2 more > {code} -- This message was sent by Atlassian JIRA (v7.6.3#76005)