[ https://issues.apache.org/jira/browse/HBASE-21734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16748589#comment-16748589 ]
Hudson commented on HBASE-21734: -------------------------------- Results for branch branch-1 [build #646 on builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/646/]: (x) *{color:red}-1 overall{color}* ---- details (if available): (x) {color:red}-1 general checks{color} -- For more information [see general report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/646//General_Nightly_Build_Report/] (x) {color:red}-1 jdk7 checks{color} -- For more information [see jdk7 report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/646//JDK7_Nightly_Build_Report/] (x) {color:red}-1 jdk8 hadoop2 checks{color} -- For more information [see jdk8 (hadoop2) report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/646//JDK8_Nightly_Build_Report_(Hadoop2)/] (x) {color:red}-1 source release artifact{color} -- See build output for details. > Some optimization in FilterListWithOR > ------------------------------------- > > Key: HBASE-21734 > URL: https://issues.apache.org/jira/browse/HBASE-21734 > Project: HBase > Issue Type: Sub-task > Reporter: Zheng Hu > Assignee: Zheng Hu > Priority: Major > Fix For: 3.0.0, 1.5.0, 2.2.0, 1.4.10, 2.1.3, 2.0.5 > > Attachments: HBASE-21734.branch-1.v1.patch, HBASE-21734.v1.patch, > columnkey.txt, perf-ut.patch > > > In HBASE-21620, [~KarthickRam] and [~mohamed.meeran] complaind that their > performance of filter list has been degraded after that patch in here [1]. > I wrote a UT for this, and test under my host. It's true. I gussed there > may be two reasons: > 1. the comparator.compare(nextKV, cell) > 0 StoreScanner; > 2. the filter list concated by OR will choose the minimal forward step among > all sub-filters. in this patch, we have stricter restrictions on all sub > filters, include those sub-filter whose has non-null RC returned in > calculateReturnCodeByPrevCellAndRC (previously, we will skip to merge this > sub-filter's rc, but it's wrong in some case), and merge all of the > sub-filter's RC, this is also some time cost. > The former one seems not the main problem, because the UT still cost ~ 3s > even if I comment the compare. the second one has some impact indeed, > because after i skip to merge the sub-filters's RC if > calculateReturnCodeByPrevCellAndRC return a non-null rc, the UT cost ~ 1s, > it's improvement but the logic is not wrong. > 1. > https://issues.apache.org/jira/browse/HBASE-21620?focusedCommentId=16737100&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16737100 -- This message was sent by Atlassian JIRA (v7.6.3#76005)