[
https://issues.apache.org/jira/browse/HBASE-4608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13228849#comment-13228849
]
Zhihong Yu commented on HBASE-4608:
-----------------------------------
Minor comments:
For findEntry():
{code}
+ public short findEntry(byte[] data, int offset, int length) {
+ short ret = backingStore.findIdx(data, offset, length);
+ if (ret == -1) {
+ addEntry(data, offset, length);
+ }
{code}
I think NOT_IN_DICTIONARY should be used in place of -1.
There're a few white spaces, e.g. at the beginning of second and third lines
below:
{code}
+ if (compressionContext == null) {
+ Bytes.writeByteArray(out, this.encodedRegionName);
+ Bytes.writeByteArray(out, this.tablename);
{code}
> HLog Compression
> ----------------
>
> Key: HBASE-4608
> URL: https://issues.apache.org/jira/browse/HBASE-4608
> Project: HBase
> Issue Type: New Feature
> Reporter: Li Pi
> Assignee: stack
> Fix For: 0.94.0
>
> Attachments: 4608-v19.txt, 4608-v20.txt, 4608-v22.txt, 4608v1.txt,
> 4608v13.txt, 4608v13.txt, 4608v14.txt, 4608v15.txt, 4608v16.txt, 4608v17.txt,
> 4608v18.txt, 4608v23.txt, 4608v5.txt, 4608v6.txt, 4608v7.txt, 4608v8fixed.txt
>
>
> The current bottleneck to HBase write speed is replicating the WAL appends
> across different datanodes. We can speed up this process by compressing the
> HLog. Current plan involves using a dictionary to compress table name, region
> id, cf name, and possibly other bits of repeated data. Also, HLog format may
> be changed in other ways to produce a smaller HLog.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
