[ 
https://issues.apache.org/jira/browse/HBASE-21738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16752576#comment-16752576
 ] 

Hudson commented on HBASE-21738:
--------------------------------

SUCCESS: Integrated in Jenkins build HBase-1.3-IT #522 (See 
[https://builds.apache.org/job/HBase-1.3-IT/522/])
HBASE-21748 Port HBASE-21738 (Remove all the CLSM#size operation in our 
(apurtell: 
[https://github.com/apache/hbase/commit/ea3dcbcea4cc4470b683bee64df482400cec82df])
* (edit) 
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestStore.java
* (edit) 
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestCellSkipListSet.java
* (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/io/TestHeapSize.java
* (edit) 
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestMemStoreChunkPool.java
* (edit) 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/CellSkipListSet.java
* (edit) 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/DefaultMemStore.java
* (edit) 
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestDefaultMemStore.java


> Remove all the CSLM#size operation in our memstore because it's an quite time 
> consuming.
> ----------------------------------------------------------------------------------------
>
>                 Key: HBASE-21738
>                 URL: https://issues.apache.org/jira/browse/HBASE-21738
>             Project: HBase
>          Issue Type: Sub-task
>          Components: Performance
>            Reporter: Zheng Hu
>            Assignee: Zheng Hu
>            Priority: Critical
>             Fix For: 3.0.0, 2.2.0, 2.1.3, 2.0.5
>
>         Attachments: HBASE-21738.v1.patch, HBASE-21738.v2.patch, 
> HBASE-21738.v3.patch, HBASE-21738.v4.patch, add-some-log.patch, 
> image-2019-01-18-14-03-28-662.png, log.txt, performance-after-the-patch.v3.png
>
>
> Made some performance test for 100% put case in branch-2 before. 
> We can see that there are many  latency peak  in p999 latency curve , and the 
> peak time are almost the point time which our region is flushing. 
> See the [hbase20-ssd-put-10000000000-rows-latencys-and-qps 
> |https://issues.apache.org/jira/secure/attachment/12955341/12955341_image-2019-01-18-14-03-28-662.png]
> And, I used the 
> [add-some-log.patch|https://issues.apache.org/jira/secure/attachment/12955342/add-some-log.patch]
>  to log some time consuming when we grab the update.writeLock() to make a 
> memstore snapshot.   Tested again, I found those logs in [log.txt. 
> |https://issues.apache.org/jira/secure/attachment/12955343/log.txt]
> Seems most of the time was consumed when taking memstore snapshot.. Let me 
> dig into this.  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to