[ https://issues.apache.org/jira/browse/HBASE-21782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16753192#comment-16753192 ]
stack commented on HBASE-21782: ------------------------------- Looks good. Mark as incompatible and needs a RN. +1. > LoadIncrementalHFiles should not be IA.Public > --------------------------------------------- > > Key: HBASE-21782 > URL: https://issues.apache.org/jira/browse/HBASE-21782 > Project: HBase > Issue Type: Task > Components: mapreduce > Reporter: Duo Zhang > Assignee: Duo Zhang > Priority: Major > Fix For: 3.0.0, 2.2.0 > > Attachments: HBASE-21782-v1.patch, HBASE-21782.patch > > > It is an implementation class, so some of the methods which are only supposed > to be used by replication sink are also public to users. And it exposes > methods which take Table and Connection as parameter and inside the > implementation we assume that they are HTable and ConnectionImplementation, > which will be a pain when we want to replace the sync client implementation > with async client. > Here I think we should make the implementation class as > IA.LimitPrivate(TOOL), and introduce an interface for bulking hfiles > programmatically. -- This message was sent by Atlassian JIRA (v7.6.3#76005)