[ https://issues.apache.org/jira/browse/HBASE-4608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13229773#comment-13229773 ]
jirapos...@reviews.apache.org commented on HBASE-4608: ------------------------------------------------------ ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4328/#review5972 ----------------------------------------------------------- src/main/java/org/apache/hadoop/hbase/regionserver/wal/CompressionContext.java <https://reviews.apache.org/r/4328/#comment12946> IllegalArgumentException is not needed here. I removed it, compiled and ran TestCompressor - it passed. src/main/java/org/apache/hadoop/hbase/regionserver/wal/Compressor.java <https://reviews.apache.org/r/4328/#comment12947> A closing ) should be placed either on this line or on line 109. src/main/java/org/apache/hadoop/hbase/regionserver/wal/Compressor.java <https://reviews.apache.org/r/4328/#comment12948> Should read 'byte of index to the ...' src/main/java/org/apache/hadoop/hbase/regionserver/wal/Compressor.java <https://reviews.apache.org/r/4328/#comment12949> Should read 'an array of bytes' src/main/java/org/apache/hadoop/hbase/regionserver/wal/Compressor.java <https://reviews.apache.org/r/4328/#comment12950> Please add javadoc for offset and length. src/main/java/org/apache/hadoop/hbase/regionserver/wal/Dictionary.java <https://reviews.apache.org/r/4328/#comment12958> Should we label this class @InterfaceAudience.Private ? src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLogKey.java <https://reviews.apache.org/r/4328/#comment12951> I don't quite get what the second sentence is supposed to convey ? It seems to be same as first sentence. This version is the minimum version that supports compression. src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLogKey.java <https://reviews.apache.org/r/4328/#comment12952> A (slightly) long line. src/main/java/org/apache/hadoop/hbase/regionserver/wal/LRUDictionary.java <https://reviews.apache.org/r/4328/#comment12954> Long line. src/main/java/org/apache/hadoop/hbase/regionserver/wal/LRUDictionary.java <https://reviews.apache.org/r/4328/#comment12955> Can we remove 'silly' here ? Some user may actually reach this size. src/main/java/org/apache/hadoop/hbase/regionserver/wal/SequenceFileLogReader.java <https://reviews.apache.org/r/4328/#comment12956> 'initiate' is used to start an action or message. 'initialize' should be used here. src/main/java/org/apache/hadoop/hbase/regionserver/wal/SequenceFileLogReader.java <https://reviews.apache.org/r/4328/#comment12957> Setting reader to null would be desirable after the close() call. - Ted On 2012-03-14 22:26:34, Michael Stack wrote: bq. bq. ----------------------------------------------------------- bq. This is an automatically generated e-mail. To reply, visit: bq. https://reviews.apache.org/r/4328/ bq. ----------------------------------------------------------- bq. bq. (Updated 2012-03-14 22:26:34) bq. bq. bq. Review request for hbase. bq. bq. bq. Summary bq. ------- bq. bq. See issue bq. bq. bq. This addresses bug hbase-4608. bq. https://issues.apache.org/jira/browse/hbase-4608 bq. bq. bq. Diffs bq. ----- bq. bq. src/main/java/org/apache/hadoop/hbase/HConstants.java 045c6f3 bq. src/main/java/org/apache/hadoop/hbase/regionserver/wal/CompressionContext.java PRE-CREATION bq. src/main/java/org/apache/hadoop/hbase/regionserver/wal/Compressor.java PRE-CREATION bq. src/main/java/org/apache/hadoop/hbase/regionserver/wal/Dictionary.java PRE-CREATION bq. src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLog.java b5049b1 bq. src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLogKey.java 311ea1b bq. src/main/java/org/apache/hadoop/hbase/regionserver/wal/KeyValueCompression.java PRE-CREATION bq. src/main/java/org/apache/hadoop/hbase/regionserver/wal/LRUDictionary.java PRE-CREATION bq. src/main/java/org/apache/hadoop/hbase/regionserver/wal/SequenceFileLogReader.java ff63a5f bq. src/main/java/org/apache/hadoop/hbase/regionserver/wal/SequenceFileLogWriter.java 01ebb5c bq. src/main/java/org/apache/hadoop/hbase/regionserver/wal/WALEdit.java d8f317c bq. src/main/java/org/apache/hadoop/hbase/util/Bytes.java de8e40b bq. src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestCompressor.java PRE-CREATION bq. src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestKeyValueCompression.java PRE-CREATION bq. src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestLRUDictionary.java PRE-CREATION bq. src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestWALReplay.java a11899c bq. src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestWALReplayCompressed.java PRE-CREATION bq. bq. Diff: https://reviews.apache.org/r/4328/diff bq. bq. bq. Testing bq. ------- bq. bq. bq. Thanks, bq. bq. Michael bq. bq. > HLog Compression > ---------------- > > Key: HBASE-4608 > URL: https://issues.apache.org/jira/browse/HBASE-4608 > Project: HBase > Issue Type: New Feature > Reporter: Li Pi > Assignee: stack > Fix For: 0.94.0 > > Attachments: 4608-v19.txt, 4608-v20.txt, 4608-v22.txt, 4608v1.txt, > 4608v13.txt, 4608v13.txt, 4608v14.txt, 4608v15.txt, 4608v16.txt, 4608v17.txt, > 4608v18.txt, 4608v23.txt, 4608v24.txt, 4608v25.txt, 4608v27.txt, 4608v29.txt, > 4608v5.txt, 4608v6.txt, 4608v7.txt, 4608v8fixed.txt, > hbase-4608-v28-delta.txt, hbase-4608-v28.txt, hbase-4608-v28.txt > > > The current bottleneck to HBase write speed is replicating the WAL appends > across different datanodes. We can speed up this process by compressing the > HLog. Current plan involves using a dictionary to compress table name, region > id, cf name, and possibly other bits of repeated data. Also, HLog format may > be changed in other ways to produce a smaller HLog. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira