[ https://issues.apache.org/jira/browse/HBASE-21201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16764154#comment-16764154 ]
Hadoop QA commented on HBASE-21201: ----------------------------------- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 12s{color} | {color:blue} Docker mode activated. {color} | || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m 0s{color} | {color:green} Patch does not have any anti-patterns. {color} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | | {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s{color} | {color:green} The patch appears to include 1 new or modified test files. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m 7s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 33s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 18s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m 6s{color} | {color:green} branch has no errors when building our shaded downstream artifacts. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m 37s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 16s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m 13s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 32s{color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} javac {color} | {color:red} 0m 32s{color} | {color:red} hbase-mapreduce generated 4 new + 154 unchanged - 4 fixed = 158 total (was 158) {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 18s{color} | {color:green} hbase-mapreduce: The patch generated 0 new + 17 unchanged - 2 fixed = 17 total (was 19) {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m 13s{color} | {color:green} patch has no errors when building our shaded downstream artifacts. {color} | | {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 8m 38s{color} | {color:green} Patch does not cause any errors with Hadoop 2.7.4 or 3.0.0. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m 45s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 15s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} unit {color} | {color:green} 14m 21s{color} | {color:green} hbase-mapreduce in the patch passed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 14s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 44m 9s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:b002b0b | | JIRA Issue | HBASE-21201 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12958131/HBASE-21201.master.004.patch | | Optional Tests | dupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 85231a7ba9df 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh | | git revision | master / abaeeace00 | | maven | version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z) | | Default Java | 1.8.0_181 | | findbugs | v3.1.0-RC3 | | javac | https://builds.apache.org/job/PreCommit-HBASE-Build/15907/artifact/patchprocess/diff-compile-javac-hbase-mapreduce.txt | | Test Results | https://builds.apache.org/job/PreCommit-HBASE-Build/15907/testReport/ | | Max. process+thread count | 5278 (vs. ulimit of 10000) | | modules | C: hbase-mapreduce U: hbase-mapreduce | | Console output | https://builds.apache.org/job/PreCommit-HBASE-Build/15907/console | | Powered by | Apache Yetus 0.8.0 http://yetus.apache.org | This message was automatically generated. > Support to run VerifyReplication MR tool without peerid > ------------------------------------------------------- > > Key: HBASE-21201 > URL: https://issues.apache.org/jira/browse/HBASE-21201 > Project: HBase > Issue Type: Improvement > Components: hbase-operator-tools > Affects Versions: 3.0.0, 2.2.0 > Reporter: Sujit P > Assignee: Toshihiro Suzuki > Priority: Major > Attachments: HBASE-21201.master.001.patch, > HBASE-21201.master.002.patch, HBASE-21201.master.003.patch, > HBASE-21201.master.003.patch, HBASE-21201.master.004.patch > > > In some use cases, hbase clients writes to separate clusters(probably > different datacenters) tables for redundancy. As an administrator/application > architect, I would like to find out if both cluster tables are in the same > state (cell by cell). One of the tools that is readily available to use is > VerifyRep which is part of replication. > However, it requires peerId to be setup on atleast of the involved cluster. > PeerId is unnecessary in this use-case scenario and possibly cause unintended > consequences as the clusters aren't really replication peers neither do We > prefer them to be. > Looking at the code: > Tool attempts to get only the clusterKey which is essentially ZooKeeper > quorum url > > {code:java} > //VerifyReplication.java > private static Pair<ReplicationPeerConfig, Configuration> > getPeerQuorumConfig(final Configuration conf, String peerId) > . > . > return Pair.newPair(peerConfig, > ReplicationUtils.getPeerClusterConfiguration(peerConfig, conf)); > //ReplicationUtils.java > public static Configuration getPeerClusterConfiguration(ReplicationPeerConfig > peerConfig, Configuration baseConf) throws ReplicationException { > Configuration otherConf; > try { > otherConf = HBaseConfiguration.createClusterConf(baseConf, > peerConfig.getClusterKey());{code} > > > So I would like to propose to update the tool to pass the remote cluster > ZkQuorum as an argument (ex. --peerQuorumAddress > clusterBzk1,clusterBzk2,clusterBzk3:2181/hbase-secure ) and use it > effectively without dependence on replication peerId, similar to > peerFSAddress. The are certain advantages in doing so as follows: > * Reduce the development/maintenance of separate tool for above scenario > * Allow the tool to be more useful for other scenarios as well such as > ** validating backups in remote cluster HBASE-19106 > ** compare cloned tableA and original tableA in same/remote cluster incase > of user error before restoring snapshot to original table to find the records > that need to be added/invalid/missing etc > ** Allow backup operators who are non-Hbase admins(who shouldn't be adding > the peerId) to run the tool, since currently only Hbase superuser can add a > peerId for reasons discussed in HBASE-21163. > Please post your comments > Thanks > cc: [~clayb], [~brfrn169] , [~vrodionov] , [~rashidaligee] -- This message was sent by Atlassian JIRA (v7.6.3#76005)