[ 
https://issues.apache.org/jira/browse/HBASE-5563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13230236#comment-13230236
 ] 

Jonathan Hsieh commented on HBASE-5563:
---------------------------------------

Hey Chenhui, looked at your code and had a question (similar to stack's) -- did 
you intend to have newer regions (larger timestamps) sorted *before* older 
HRegionInfos?  If so why?  My intuition says to to have newer regions sorted 
after older ones.  At the moment nothing depends on one order vs another, so I 
would like to add some simple unit tests to make the desired behavior this 
explicitly tested.  

Also, I have a few runs with the broken test passing now (a bunch of tests seem 
to be flakey on my setup). 
                
> HRegionInfo#compareTo add the comparison of regionId
> ----------------------------------------------------
>
>                 Key: HBASE-5563
>                 URL: https://issues.apache.org/jira/browse/HBASE-5563
>             Project: HBase
>          Issue Type: Bug
>            Reporter: chunhui shen
>            Assignee: chunhui shen
>         Attachments: HBASE-5563.patch, HBASE-5563v2.patch, HBASE-5563v2.patch
>
>
> In the one region multi assigned case,  we could find that two regions have 
> the same table name, same startKey, same endKey, and different regionId, so 
> these two regions are same in TreeMap but different in HashMap.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to