[ https://issues.apache.org/jira/browse/HBASE-18484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16764887#comment-16764887 ]
Hadoop QA commented on HBASE-18484: ----------------------------------- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 12s{color} | {color:blue} Docker mode activated. {color} | || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m 0s{color} | {color:green} Patch does not have any anti-patterns. {color} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | | {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s{color} | {color:green} The patch appears to include 1 new or modified test files. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 22s{color} | {color:blue} Maven dependency ordering for branch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m 37s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m 35s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m 35s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m 36s{color} | {color:green} branch has no errors when building our shaded downstream artifacts. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m 56s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 45s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 14s{color} | {color:blue} Maven dependency ordering for patch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m 39s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m 36s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 2m 36s{color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 18s{color} | {color:red} hbase-mapreduce: The patch generated 3 new + 12 unchanged - 0 fixed = 15 total (was 12) {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m 32s{color} | {color:green} patch has no errors when building our shaded downstream artifacts. {color} | | {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 9m 55s{color} | {color:green} Patch does not cause any errors with Hadoop 2.7.4 or 3.0.0. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m 15s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 45s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} unit {color} | {color:green}131m 2s{color} | {color:green} hbase-server in the patch passed. {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 17m 16s{color} | {color:green} hbase-mapreduce in the patch passed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 50s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black}195m 4s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:b002b0b | | JIRA Issue | HBASE-18484 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12958215/HBASE-18484.v3.patch | | Optional Tests | dupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux d1f6da2f55a5 4.4.0-139-generic #165~14.04.1-Ubuntu SMP Wed Oct 31 10:55:11 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh | | git revision | master / c48438fcb0 | | maven | version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z) | | Default Java | 1.8.0_181 | | findbugs | v3.1.0-RC3 | | checkstyle | https://builds.apache.org/job/PreCommit-HBASE-Build/15922/artifact/patchprocess/diff-checkstyle-hbase-mapreduce.txt | | Test Results | https://builds.apache.org/job/PreCommit-HBASE-Build/15922/testReport/ | | Max. process+thread count | 5118 (vs. ulimit of 10000) | | modules | C: hbase-server hbase-mapreduce U: . | | Console output | https://builds.apache.org/job/PreCommit-HBASE-Build/15922/console | | Powered by | Apache Yetus 0.8.0 http://yetus.apache.org | This message was automatically generated. > VerifyRep by snapshot does not work when Yarn / SourceHBase / PeerHBase > located in different HDFS clusters > ----------------------------------------------------------------------------------------------------------- > > Key: HBASE-18484 > URL: https://issues.apache.org/jira/browse/HBASE-18484 > Project: HBase > Issue Type: Bug > Components: Replication > Affects Versions: 2.0.0-alpha-1 > Reporter: Zheng Hu > Assignee: Zheng Hu > Priority: Major > Attachments: HBASE-18484.v1.patch, HBASE-18484.v2.patch, > HBASE-18484.v3.patch > > > As HBASE-16466 commented. > Seems like that when source hbase cluster / peer hbase cluster / yarn cluster > locate in three different HDFS cluster , it has one problem. > when restoring the snapshot into tmpdir , we need to create region by > following code (HRegion#createHRegion) > {code} > public static HRegion createHRegion(final HRegionInfo info, final Path > rootDir, > final Configuration conf, final TableDescriptor hTableDescriptor, > final WAL wal, final boolean initialize) > throws IOException { > LOG.info("creating HRegion " + info.getTable().getNameAsString() > + " HTD == " + hTableDescriptor + " RootDir = " + rootDir + > " Table name == " + info.getTable().getNameAsString()); > FileSystem fs = FileSystem.get(conf); > <------------------- Here our code use fs.defaultFs configuration to create > region. > Path tableDir = FSUtils.getTableDir(rootDir, info.getTable()); > HRegionFileSystem.createRegionOnFileSystem(conf, fs, tableDir, info); > HRegion region = HRegion.newHRegion(tableDir, wal, fs, conf, info, > hTableDescriptor, null); > if (initialize) region.initialize(null); > return region; > } > {code} > When source cluster & peer cluster locate in two difference file systems , > then their fs.defaultFs should be difference, so at least one cluster will > fail when restore snapshot into tmpdir . after I added the following fix, it > works fine for me. > {code} > -FileSystem fs = FileSystem.get(conf); > +FileSystem fs = rootDir.getFileSystem(conf); > {code} -- This message was sent by Atlassian JIRA (v7.6.3#76005)