[ 
https://issues.apache.org/jira/browse/HBASE-5584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13230368#comment-13230368
 ] 

Mingjie Lai commented on HBASE-5584:
------------------------------------

Ramkrishna. 
One thing you need to take into consideration is hbase ACL. Right now table 
level permission control (table creation, enabling, etc) is performed at master 
preCreate, preEnable e.g. hooks, and a request gets denied by throwing an 
exception. 
If you want to move preXXX to handler threads, the ACL exception cannot be 
handled properly to indicate a permission rejection. So in this case, if a user 
tries to delete someone else's tables, she won't see any exception although the 
request has been rejected. 
                
> Coprocessor hooks can be called in the respective handlers
> ----------------------------------------------------------
>
>                 Key: HBASE-5584
>                 URL: https://issues.apache.org/jira/browse/HBASE-5584
>             Project: HBase
>          Issue Type: Improvement
>          Components: coprocessors
>            Reporter: ramkrishna.s.vasudevan
>            Assignee: ramkrishna.s.vasudevan
>             Fix For: 0.96.0
>
>
> Following points can be changed w.r.t to coprocessors
> -> Call preCreate, postCreate, preEnable, postEnable, etc. in their 
> respective handlers
> -> Currently it is called in the HMaster thus making the postApis async w.r.t 
> the handlers
> -> Similar is the case with the balancer.
> with current behaviour once we are in the postEnable(for eg) we any way need 
> to wait for the main enable handler to 
> be completed.
> We should ensure that we dont wait in the main thread so again we need to 
> spawn a thread and wait on that.
> On the other hand if the pre and post api is called on the handlers then only 
> that handler thread will be
> used in the pre/post apis
> If the above said plan is ok i can prepare a patch for all such related 
> changes.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to