[ https://issues.apache.org/jira/browse/HBASE-5549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13230457#comment-13230457 ]
Hadoop QA commented on HBASE-5549: ---------------------------------- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12518500/5549.v6.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 20 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 161 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: org.apache.hadoop.hbase.replication.TestReplication org.apache.hadoop.hbase.client.TestMultiParallel Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1193//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1193//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1193//console This message is automatically generated. > Master can fail if ZooKeeper session expires > -------------------------------------------- > > Key: HBASE-5549 > URL: https://issues.apache.org/jira/browse/HBASE-5549 > Project: HBase > Issue Type: Bug > Components: master, zookeeper > Affects Versions: 0.96.0 > Environment: all > Reporter: nkeywal > Assignee: nkeywal > Priority: Minor > Attachments: 5549.v6.patch > > > There is a retry mechanism in RecoverableZooKeeper, but when the session > expires, the whole ZooKeeperWatcher is recreated, hence the retry mechanism > does not work in this case. This is why a sleep is needed in > TestZooKeeper#testMasterSessionExpired: we need to wait for ZooKeeperWatcher > to be recreated before using the connection. > This can happen in real life, it can happen when: > - master & zookeeper starts > - zookeeper connection is cut > - master enters the retry loop > - in the meantime the session expires > - the network comes back, the session is recreated > - the retries continues, but on the wrong object, hence fails. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira