[
https://issues.apache.org/jira/browse/HBASE-21872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16766221#comment-16766221
]
Josh Elser commented on HBASE-21872:
------------------------------------
{quote}This looks like a great plugin. Tried this and the results look great.
{quote}
Thanks for investigating, Nihal. Watching your HBASE-21881
{quote}if it looks like it has reasonable feedback on a few patches we can
switch it to voting.
{quote}
+1
{quote}+1 on v2
I'm confused by the results from QABot. e.g. complaints about
{{TestZooKeeperACL.java}} that AFAICT are not caused by your patch.
{quote}
Thanks for the review, Busbey. This is more lingering issues. It's complaining
about constructing a String from bytes without specifying a charset (whereas I
was fixing encoding a String into bytes without specifying a charset). Let me
just fix those, too, since I have some more checkstyle things to address WRT
line length and indentation :)
> Clean up getBytes() calls without charsets provided
> ---------------------------------------------------
>
> Key: HBASE-21872
> URL: https://issues.apache.org/jira/browse/HBASE-21872
> Project: HBase
> Issue Type: Task
> Reporter: Josh Elser
> Assignee: Josh Elser
> Priority: Trivial
> Fix For: 3.0.0
>
> Attachments: HBASE-21782.001.patch, HBASE-21782.002.patch
>
>
> As we saw over in HBASE-21201, the use of {{String.getBytes()}} without a
> Charset can result is some compiler warnings. Let's just get rid of these
> calls. There are only a handful anymore in master.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
