[
https://issues.apache.org/jira/browse/HBASE-5581?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Phabricator updated HBASE-5581:
-------------------------------
Attachment: D2343.1.patch
binujohn7 requested code review of "[jira] [HBASE-5581] [89-fb] Creating a
table with invalid syntax does not give an error message when it fails".
Reviewers: JIRA, Kannan
Creating a table with invalid syntax does not give an error message when it
fails. In this case, it doesn't actually create the CF requested, but doesn't
give any indication to the user that it failed. Throw an error in case of
invalid table creation syntax.
Fix a typo in the error message when NUMREGIONS <= 1.
TEST PLAN
Try to create a table with an invalid command as follows -
create 'test', {NAME => 'test', VERSIONS => 1, BLOCKCACHE => true, NUMREGIONS
=> 20, SPLITALGO => "HexStringSplit", COMPRESSION => 'LZO', BLOOMFILTER =>
'ROW'}
This should report an error.
Verify that the table is created correctly when the column family
configuration is specified in a separate clause as shown below
create 'test', {NAME => 'test', VERSIONS => 1, BLOCKCACHE => true,
COMPRESSION => 'LZO', BLOOMFILTER => 'ROW'}, {NUMREGIONS => 20, SPLITALGO =>
"HexStringSplit"}
REVISION DETAIL
https://reviews.facebook.net/D2343
AFFECTED FILES
src/main/ruby/hbase/admin.rb
MANAGE HERALD DIFFERENTIAL RULES
https://reviews.facebook.net/herald/view/differential/
WHY DID I GET THIS EMAIL?
https://reviews.facebook.net/herald/transcript/5193/
Tip: use the X-Herald-Rules header to filter Herald messages in your client.
> Creating a table with invalid syntax does not give an error message when it
> fails
> ---------------------------------------------------------------------------------
>
> Key: HBASE-5581
> URL: https://issues.apache.org/jira/browse/HBASE-5581
> Project: HBase
> Issue Type: Bug
> Components: shell
> Reporter: Binu John
> Priority: Minor
> Attachments: D2343.1.patch
>
>
> Creating a table with invalid syntax does not give an error message when it
> fails. In this case, it doesn't actually create the CF requested, but doesn't
> give any indication to the user that it failed.
> create 'test', {NAME => 'test', VERSIONS => 1, BLOCKCACHE => true, NUMREGIONS
> => 20, SPLITALGO => "HexStringSplit", COMPRESSION => 'LZO', BLOOMFILTER =>
> 'ROW'}
> 0 row(s) in 3.0930 seconds
> hbase(main):002:0> describe 'test'
> DESCRIPTION
> ENABLED
> {NAME => 'test', FAMILIES => []}
> true
> 1 row(s) in 0.1430 seconds
> ----
> Putting {NUMREGIONS => 20, SPLITALGO => "HexStringSplit"} into a separate
> stanza works fine, so the feature is fine.
> create 'test', {NAME => 'test', VERSIONS => 1, BLOCKCACHE => true,
> COMPRESSION => 'LZO', BLOOMFILTER => 'ROW'}, {NUMREGIONS => 20, SPLITALGO =>
> "HexStringSplit"}
> 0 row(s) in 2.7860 seconds
> hbase(main):002:0> describe 'test'
> DESCRIPTION
> ENABLED
> {NAME => 'test', FAMILIES => [{NAME => 'test', DATA_BLOCK_ENCODING =>
> 'NONE', true
> BLOOMFILTER => 'ROW', REPLICATION_SCOPE => '0', COMPRESSION => 'LZO',
> VERSIONS
> => '1', TTL => '2147483647', BLOCKSIZE => '65536', BLOOMFILTER_ERRORRATE =>
> '
> 0.01', ENCODE_ON_DISK => 'true', IN_MEMORY => 'false', BLOCKCACHE =>
> 'true'}]}
> ----
> We should throw an error if we can't create the CF so it's clear to the user.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
