[
https://issues.apache.org/jira/browse/HBASE-21875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16767031#comment-16767031
]
Duo Zhang commented on HBASE-21875:
-----------------------------------
OK, confirmed. The UncaughtExceptionHandler will only be invoked if you use the
execute method to submit the task. If you use the submit, the
UncaughtExceptionHandler will not be invoked. And this is reasonble, as submit
method will return a Future, so you can get the result through the Future. And
this is why error prone has a FutureReturnValueIgnored warning.
So here I think either we change to use execute method, or we need to eat the
return Future object. I prefer the former one as here we do not care the return
value, and if we want to eat the Future, we need to use the executors from
guava so it will return a ListenableFuture...
Let me open another issue to fix this. As this should be integrated to all 2.0+
branches.
> Change the retry logic in RSProcedureDispatcher to 'retry by default, only if
> xxx'
> ----------------------------------------------------------------------------------
>
> Key: HBASE-21875
> URL: https://issues.apache.org/jira/browse/HBASE-21875
> Project: HBase
> Issue Type: Improvement
> Components: proc-v2
> Reporter: Duo Zhang
> Assignee: Duo Zhang
> Priority: Major
> Fix For: 3.0.0, 2.2.0, 2.3.0
>
> Attachments: HBASE-21875-v1.patch, HBASE-21875-v2.patch,
> HBASE-21875.patch
>
>
> For now it is not retry by default, only if xxx.
> In executeProcedures, we will only throw a fixed set of exception, so we
> should change to retry by default, and check for the exceptions which we do
> not need to retry.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
