[
https://issues.apache.org/jira/browse/HBASE-21881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16767104#comment-16767104
]
Nihal Jain edited comment on HBASE-21881 at 2/13/19 12:24 PM:
--------------------------------------------------------------
{noformat}
Search "Forbidden method invocation" (362 hits in 1 file)
Search "Deprecated in Java 1.8" (9 hits in 1 file)
Search "Reflection usage to work around " (44 hits in 1 file)
Search "[Uses default charset]" (73 hits in 1 file)
Search "Uses default locale" (237 hits in 1 file)
{noformat}
I think the number of errors are not very large, and I can fix them, if asked
to? [~elserj] is already taking care of around ~50 of them.
Also I had a look at several projects using forbiddenapis, none of them were
banning reflection. Do we need to ban it?
NOTE: Results are only for source classes
was (Author: nihaljain.cs):
{noformat}
Search "Forbidden method invocation" (362 hits in 1 file)
Search "Deprecated in Java 1.8" (9 hits in 1 file)
Search "Reflection usage to work around " (44 hits in 1 file)
Search "[Uses default charset]" (73 hits in 1 file)
Search "Uses default locale" (237 hits in 1 file)
{noformat}
I think the number of errors are not very large, and I can fix them, if asked
to?
Also I had a look at several projects using forbiddenapis, none of them were
banning reflection. Do we need to ban it?
> Use Forbidden API Checker to prevent future usages of forbidden api's
> ---------------------------------------------------------------------
>
> Key: HBASE-21881
> URL: https://issues.apache.org/jira/browse/HBASE-21881
> Project: HBase
> Issue Type: Improvement
> Components: build
> Reporter: Nihal Jain
> Assignee: Nihal Jain
> Priority: Major
> Attachments: forbiddenapis.out
>
>
> [Policeman's Forbidden API
> Checker|https://github.com/policeman-tools/forbidden-apis] provides an
> elegant way to fail build if any "forbidden api" is used in the code base.
> Here we will add the plugin to our pom.xml.
> We will discuss which all api's to put in forbidden list. Or whether to use
> the one's bundled with the plugin.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
