[ https://issues.apache.org/jira/browse/HBASE-21960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16778813#comment-16778813 ]
Hadoop QA commented on HBASE-21960: ----------------------------------- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 14s{color} | {color:blue} Docker mode activated. {color} | || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m 0s{color} | {color:green} Patch does not have any anti-patterns. {color} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | | {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s{color} | {color:green} The patch appears to include 5 new or modified test files. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m 15s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 45s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 21s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 5m 37s{color} | {color:green} branch has no errors when building our shaded downstream artifacts. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m 57s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 21s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m 46s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 41s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 41s{color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 18s{color} | {color:red} hbase-rest: The patch generated 9 new + 33 unchanged - 9 fixed = 42 total (was 42) {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m 2s{color} | {color:green} The patch has no ill-formed XML file. {color} | | {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m 54s{color} | {color:green} patch has no errors when building our shaded downstream artifacts. {color} | | {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 9m 33s{color} | {color:green} Patch does not cause any errors with Hadoop 2.7.4 or 3.0.0. {color} | | {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m 55s{color} | {color:red} hbase-rest generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0) {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 19s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} unit {color} | {color:green} 4m 10s{color} | {color:green} hbase-rest in the patch passed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 10s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 39m 48s{color} | {color:black} {color} | \\ \\ || Reason || Tests || | FindBugs | module:hbase-rest | | | org.apache.hadoop.hbase.rest.RESTServer.conf isn't final and can't be protected from malicious code At RESTServer.java:be protected from malicious code At RESTServer.java:[line 106] | | | Write to static field org.apache.hadoop.hbase.rest.RESTServer.conf from instance method new org.apache.hadoop.hbase.rest.RESTServer(Configuration) At RESTServer.java:from instance method new org.apache.hadoop.hbase.rest.RESTServer(Configuration) At RESTServer.java:[line 112] | \\ \\ || Subsystem || Report/Notes || | Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:b002b0b | | JIRA Issue | HBASE-21960 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12960268/HBASE-21960.005.patch | | Optional Tests | dupname asflicense javac javadoc unit shadedjars hadoopcheck xml compile findbugs hbaseanti checkstyle | | uname | Linux 8a3e96228f00 4.4.0-138-generic #164~14.04.1-Ubuntu SMP Fri Oct 5 08:56:16 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh | | git revision | master / c33ceb23d3 | | maven | version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z) | | Default Java | 1.8.0_181 | | findbugs | v3.1.11 | | checkstyle | https://builds.apache.org/job/PreCommit-HBASE-Build/16139/artifact/patchprocess/diff-checkstyle-hbase-rest.txt | | findbugs | https://builds.apache.org/job/PreCommit-HBASE-Build/16139/artifact/patchprocess/new-findbugs-hbase-rest.html | | Test Results | https://builds.apache.org/job/PreCommit-HBASE-Build/16139/testReport/ | | Max. process+thread count | 2084 (vs. ulimit of 10000) | | modules | C: hbase-rest U: hbase-rest | | Console output | https://builds.apache.org/job/PreCommit-HBASE-Build/16139/console | | Powered by | Apache Yetus 0.8.0 http://yetus.apache.org | This message was automatically generated. > RESTServletContainer not configured for REST Jetty server > --------------------------------------------------------- > > Key: HBASE-21960 > URL: https://issues.apache.org/jira/browse/HBASE-21960 > Project: HBase > Issue Type: Bug > Components: REST > Reporter: Josh Elser > Assignee: Josh Elser > Priority: Blocker > Fix For: 3.0.0, 2.2.0, 2.0.5, 2.1.4 > > Attachments: HBASE-21960.001.patch, HBASE-21960.002.patch, > HBASE-21960.003.patch, HBASE-21960.004.patch, HBASE-21960.005.patch > > > The upgrade to Jetty 9 (HBASE-12894) appears to have missed including the > RESTServletContainer as the base servlet for Jetty. Make sure we configure > that class. > I also have some testing to prevent a regression again in the future. -- This message was sent by Atlassian JIRA (v7.6.3#76005)