[ 
https://issues.apache.org/jira/browse/HBASE-20754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16779598#comment-16779598
 ] 

Sean Busbey commented on HBASE-20754:
-------------------------------------

this bit here:
{code:java}
75 .Example extract from _hbase-env.sh_ where JAVA_HOME is set
76      
77        # Set environment variables here.
78      
79        # The java implementation to use. Java 1.6 required.
80        export JAVA_HOME=/usr/jdk64/jdk1.8.0_112
{code}

Isn't treating the blank line on #78 as a part of the same block. Maybe it 
needs to be non-empty?

Also the comment says Java 1.6 required, but Java 1.6 is expressly not allowed 
for any current release line.

{code}
70      . Set the `JAVA_HOME` environment variable before starting HBase. HBase 
provides a central mechanism to set `JAVA_HOME`. To set `JAVA_HOME`,
71        Locate where Java is installed on your machine using the _whereis 
java_ command.
72        Edit the _conf/hbase-env.sh_ file, uncomment the line starting with 
_#export JAVA_HOME=_,
73        and then set it to your Java installation path.
{code}

The first few lines could flow better. Maybe something like
{quote}
You must set the `JAVA_HOME` environment variable before starting HBase. To 
make this easier, you can do so within the _conf/hbase-env.sh_ file. You will 
need to locate where java is installed on your machine. One way to do this is 
with the _whereis java_ command. Once you have the location, edit the 
_conf/hbase-env.sh_ file and uncomment...[the rest]
{quote}

> quickstart guide should instruct folks to set JAVA_HOME to a JDK installation.
> ------------------------------------------------------------------------------
>
>                 Key: HBASE-20754
>                 URL: https://issues.apache.org/jira/browse/HBASE-20754
>             Project: HBase
>          Issue Type: Bug
>          Components: documentation
>    Affects Versions: 3.0.0
>            Reporter: Sean Busbey
>            Assignee: Gokul
>            Priority: Major
>              Labels: beginner
>             Fix For: 3.0.0
>
>         Attachments: HBASE-20754.patch
>
>
> The quickstart guide currently instructs folks to set JAVA_HOME, but to the 
> wrong place
> {code}
> The JAVA_HOME variable should be set to a directory which contains the 
> executable file bin/java. Most modern Linux operating systems provide a 
> mechanism, such as /usr/bin/alternatives on RHEL or CentOS, for transparently 
> switching between versions of executables such as Java. In this case, you can 
> set JAVA_HOME to the directory containing the symbolic link to bin/java, 
> which is usually /usr.
> JAVA_HOME=/usr
> {code}
> instead, it should tell folks to point it to a jdk installation and help them 
> on how to find that.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to