[
https://issues.apache.org/jira/browse/HBASE-5597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13231817#comment-13231817
]
Uma Maheswara Rao G commented on HBASE-5597:
--------------------------------------------
Hi David,
Problem with just upping the count is, later if you remove some code(contains
current findbugs warnings) and add new code(introduce some valid findbugs).
Then test-patch may not make difference due to this OK count.
Instead, we can add findbugs-exclude file right? this may point the exact place
of the findbug to ignore.
What do you say?
> Findbugs check in test-patch.sh always fails
> --------------------------------------------
>
> Key: HBASE-5597
> URL: https://issues.apache.org/jira/browse/HBASE-5597
> Project: HBase
> Issue Type: Bug
> Components: scripts
> Affects Versions: 0.92.1, 0.94.0, 0.96.0
> Reporter: David S. Wang
> Assignee: David S. Wang
> Attachments: HBASE-5597.patch
>
>
> "Fix" is to bump up OK findbugs count in test-patch.properties. Agreed to on
> the list.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
