[
https://issues.apache.org/jira/browse/HBASE-21874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16783729#comment-16783729
]
Wellington Chevreuil commented on HBASE-21874:
----------------------------------------------
Hi [~ram_krish], [~anoop.hbase], had done some simple, manual tests on the
latest patch that includes the refactory, and it looks good for me. Tested all
existing bucket cache engines plus the added pmem to make sure there wouldn't
be any regression.
A minor cosmetic suggestion, though: Perhaps, *ExclusiveMemoryMmapIOEngine*
does not need to override ***usesSharedMemory* method, as *IOEngine* interface
already defines default behaviour to return false.
> Bucket cache on Persistent memory
> ---------------------------------
>
> Key: HBASE-21874
> URL: https://issues.apache.org/jira/browse/HBASE-21874
> Project: HBase
> Issue Type: New Feature
> Components: BucketCache
> Affects Versions: 3.0.0
> Reporter: ramkrishna.s.vasudevan
> Assignee: ramkrishna.s.vasudevan
> Priority: Major
> Fix For: 3.0.0
>
> Attachments: HBASE-21874.patch, HBASE-21874.patch,
> HBASE-21874_V2.patch, HBASE-21874_V4.patch, HBASE-21874_V5.patch, Pmem_BC.png
>
>
> Non volatile persistent memory devices are byte addressable like DRAM (for
> eg. Intel DCPMM). Bucket cache implementation can take advantage of this new
> memory type and can make use of the existing offheap data structures to serve
> data directly from this memory area without having to bring the data to
> onheap.
> The patch is a new IOEngine implementation that works with the persistent
> memory.
> Note : Here we don't make use of the persistence nature of the device and
> just make use of the big memory it provides.
> Performance numbers to follow.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
