[ https://issues.apache.org/jira/browse/HBASE-21959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16788367#comment-16788367 ]
Xu Cang commented on HBASE-21959: --------------------------------- applied to master, branch-2, branch2.2 For branch-1 since the unit test directory structure is different, can you provide a separate patch for branch-1? Appreciate it. for the unit test, it might need to go hbase-server folder and org.apache.hadoop.hbase.mapreduce package. Also the "HStore" class is different in branch-1, some minor changes are needed. Thanks again. [~wchevreuil] > CompactionTool should close the store it uses for compacting files, in order > to properly archive compacted files. > ----------------------------------------------------------------------------------------------------------------- > > Key: HBASE-21959 > URL: https://issues.apache.org/jira/browse/HBASE-21959 > Project: HBase > Issue Type: Bug > Components: tooling > Reporter: Wellington Chevreuil > Assignee: Wellington Chevreuil > Priority: Major > Attachments: HBASE-21959-master-001.patch, > HBASE-21959-master-002.patch, HBASE-21959-master-003.patch > > > While using CompactionTool to offload RSes, noticed compacted files were > never archived from original region dir, causing the space used by the region > to actually double. Going through its compaction related code on HStore, > which is used by CompactionTool for performing compactions, found out what > that compacted files archiving happens mainly while closing the HStore > instance. CompactionTool is never explicitly closing its HStore instance, so > adding a simple patch that properly close the store. -- This message was sent by Atlassian JIRA (v7.6.3#76005)