[ https://issues.apache.org/jira/browse/HBASE-21456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16788524#comment-16788524 ]
Hadoop QA commented on HBASE-21456: ----------------------------------- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 23s{color} | {color:blue} Docker mode activated. {color} | || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m 0s{color} | {color:green} Patch does not have any anti-patterns. {color} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | | {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s{color} | {color:green} The patch appears to include 63 new or modified test files. {color} | || || || || {color:brown} HBASE-20952 Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 1m 28s{color} | {color:blue} Maven dependency ordering for branch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 6m 30s{color} | {color:green} HBASE-20952 passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 3m 7s{color} | {color:green} HBASE-20952 passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 2m 5s{color} | {color:green} HBASE-20952 passed {color} | | {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m 41s{color} | {color:green} branch has no errors when building our shaded downstream artifacts. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m 32s{color} | {color:green} HBASE-20952 passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 3s{color} | {color:green} HBASE-20952 passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 19s{color} | {color:blue} Maven dependency ordering for patch {color} | | {color:red}-1{color} | {color:red} mvninstall {color} | {color:red} 4m 6s{color} | {color:red} root in the patch failed. {color} | | {color:red}-1{color} | {color:red} compile {color} | {color:red} 0m 30s{color} | {color:red} hbase-mapreduce in the patch failed. {color} | | {color:red}-1{color} | {color:red} javac {color} | {color:red} 2m 18s{color} | {color:red} hbase-server generated 1 new + 187 unchanged - 1 fixed = 188 total (was 188) {color} | | {color:red}-1{color} | {color:red} javac {color} | {color:red} 0m 30s{color} | {color:red} hbase-mapreduce in the patch failed. {color} | | {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 1m 34s{color} | {color:red} hbase-server: The patch generated 72 new + 934 unchanged - 2 fixed = 1006 total (was 936) {color} | | {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 21s{color} | {color:red} hbase-mapreduce: The patch generated 1 new + 2 unchanged - 0 fixed = 3 total (was 2) {color} | | {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m 0s{color} | {color:red} The patch has 9 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply {color} | | {color:red}-1{color} | {color:red} shadedjars {color} | {color:red} 4m 5s{color} | {color:red} patch has 14 errors when building our shaded downstream artifacts. {color} | | {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 2m 30s{color} | {color:red} The patch causes 14 errors with Hadoop v2.7.4. {color} | | {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 5m 10s{color} | {color:red} The patch causes 14 errors with Hadoop v3.0.0. {color} | | {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m 23s{color} | {color:red} hbase-mapreduce in the patch failed. {color} | | {color:red}-1{color} | {color:red} javadoc {color} | {color:red} 0m 37s{color} | {color:red} hbase-server generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) {color} | || || || || {color:brown} Other Tests {color} || | {color:red}-1{color} | {color:red} unit {color} | {color:red}271m 41s{color} | {color:red} hbase-server in the patch failed. {color} | | {color:red}-1{color} | {color:red} unit {color} | {color:red} 0m 38s{color} | {color:red} hbase-mapreduce in the patch failed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 53s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black}319m 34s{color} | {color:black} {color} | \\ \\ || Reason || Tests || | Failed junit tests | hadoop.hbase.client.TestScannerTimeout | | | hadoop.hbase.replication.TestSyncReplicationMoreLogsInLocalGiveUpSplitting | | | hadoop.hbase.replication.TestSyncReplicationStandbyKillRS | | | hadoop.hbase.client.TestFromClientSideWithCoprocessor | | | hadoop.hbase.client.TestSnapshotTemporaryDirectoryWithRegionReplicas | | | hadoop.hbase.master.assignment.TestRegionMoveAndAbandon | | | hadoop.hbase.master.TestSplitRegionWhileRSCrash | | | hadoop.hbase.security.visibility.TestVisibilityLabelsWithDefaultVisLabelService | | | hadoop.hbase.master.procedure.TestProcedurePriority | | | hadoop.hbase.regionserver.wal.TestLogRolling | | | hadoop.hbase.master.procedure.TestServerCrashProcedureWithReplicas | | | hadoop.hbase.regionserver.wal.TestAsyncLogRolling | | | hadoop.hbase.regionserver.TestRegionServerAbortTimeout | | | hadoop.hbase.master.TestMergeTableRegionsWhileRSCrash | | | hadoop.hbase.TestMetaTableAccessor | | | hadoop.hbase.TestIOFencing | | | hadoop.hbase.regionserver.TestRegionReplicaFailover | | | hadoop.hbase.regionserver.TestSplitWalDataLoss | \\ \\ || Subsystem || Report/Notes || | Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:b002b0b | | JIRA Issue | HBASE-21456 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12961779/HBASE-21456.HBASE-20952.002.patch | | Optional Tests | dupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux c52c029d16be 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh | | git revision | HBASE-20952 / 5e55f772c7 | | maven | version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z) | | Default Java | 1.8.0_181 | | findbugs | v3.1.0-RC3 | | mvninstall | https://builds.apache.org/job/PreCommit-HBASE-Build/16312/artifact/patchprocess/patch-mvninstall-root.txt | | compile | https://builds.apache.org/job/PreCommit-HBASE-Build/16312/artifact/patchprocess/patch-compile-hbase-mapreduce.txt | | javac | https://builds.apache.org/job/PreCommit-HBASE-Build/16312/artifact/patchprocess/diff-compile-javac-hbase-server.txt | | javac | https://builds.apache.org/job/PreCommit-HBASE-Build/16312/artifact/patchprocess/patch-compile-hbase-mapreduce.txt | | checkstyle | https://builds.apache.org/job/PreCommit-HBASE-Build/16312/artifact/patchprocess/diff-checkstyle-hbase-server.txt | | checkstyle | https://builds.apache.org/job/PreCommit-HBASE-Build/16312/artifact/patchprocess/diff-checkstyle-hbase-mapreduce.txt | | whitespace | https://builds.apache.org/job/PreCommit-HBASE-Build/16312/artifact/patchprocess/whitespace-eol.txt | | shadedjars | https://builds.apache.org/job/PreCommit-HBASE-Build/16312/artifact/patchprocess/patch-shadedjars.txt | | hadoopcheck | https://builds.apache.org/job/PreCommit-HBASE-Build/16312/artifact/patchprocess/patch-javac-2.7.4.txt | | hadoopcheck | https://builds.apache.org/job/PreCommit-HBASE-Build/16312/artifact/patchprocess/patch-javac-3.0.0.txt | | findbugs | https://builds.apache.org/job/PreCommit-HBASE-Build/16312/artifact/patchprocess/patch-findbugs-hbase-mapreduce.txt | | javadoc | https://builds.apache.org/job/PreCommit-HBASE-Build/16312/artifact/patchprocess/diff-javadoc-javadoc-hbase-server.txt | | unit | https://builds.apache.org/job/PreCommit-HBASE-Build/16312/artifact/patchprocess/patch-unit-hbase-server.txt | | unit | https://builds.apache.org/job/PreCommit-HBASE-Build/16312/artifact/patchprocess/patch-unit-hbase-mapreduce.txt | | Test Results | https://builds.apache.org/job/PreCommit-HBASE-Build/16312/testReport/ | | Max. process+thread count | 4941 (vs. ulimit of 10000) | | modules | C: hbase-server hbase-mapreduce U: . | | Console output | https://builds.apache.org/job/PreCommit-HBASE-Build/16312/console | | Powered by | Apache Yetus 0.8.0 http://yetus.apache.org | This message was automatically generated. > Make WALFactory only used for creating WALProviders > --------------------------------------------------- > > Key: HBASE-21456 > URL: https://issues.apache.org/jira/browse/HBASE-21456 > Project: HBase > Issue Type: Sub-task > Components: wal > Affects Versions: HBASE-20952 > Reporter: Josh Elser > Assignee: Ankit Singhal > Priority: Major > Fix For: HBASE-20952 > > Attachments: HBASE-21456.HBASE-20952.001.patch, > HBASE-21456.HBASE-20952.002.patch, HBASE-21456.HBASE-20952.wip.patch > > > As a Factory, WALFactory should only have one job: creating instances of > WALProvider. > However, over the years, it has been a landing place for lots of wal-related > methods (e.g. constructing readers, WALEntryStream, and more). We want all of > this to live in the WALProvider. > We can do this in two steps: have the WALFactory methods invoke the method on > the WALProvider (handled elsewhere), then here we can replace usage of the > WALFactory "wrapper methods" with the WALProvider itself. -- This message was sent by Atlassian JIRA (v7.6.3#76005)