[ 
https://issues.apache.org/jira/browse/HBASE-21895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16795020#comment-16795020
 ] 

Kevin Risden commented on HBASE-21895:
--------------------------------------

Latest patch just adds a comment about where the magic property comes from for 
building with JDK 8. The official error prone docs say to use another profile 
activated by JDK 8. That seems weird to me to have it always be activated with 
JDK 8. I included it in the errorProne profile since it looks like HBase is 
currently only built with JDK 8. If/when building with JDK9+ need to look at 
the errorProne module again.

> Take more care on the error prone plugin and warnings
> -----------------------------------------------------
>
>                 Key: HBASE-21895
>                 URL: https://issues.apache.org/jira/browse/HBASE-21895
>             Project: HBase
>          Issue Type: Umbrella
>          Components: build
>            Reporter: Duo Zhang
>            Assignee: Kevin Risden
>            Priority: Major
>         Attachments: HBASE-21895.master.001.patch, 
> HBASE-21895.master.002.patch, HBASE-21895.master.003.patch
>
>
> As shown in HBASE-21890 , the error prone warnings are truly useful.
> But now, the javac warnings section in the pre commit result is messed up, it 
> always reports unrelated warnings. Need to take a look at it.
> And also, we should try out best to clean up the warnings.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to