[ https://issues.apache.org/jira/browse/HBASE-22051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16795684#comment-16795684 ]
Xu Cang commented on HBASE-22051: --------------------------------- Thanks [~water] Do you mind provide branch-1 patch at the same time and I will apply them together. Thanks ;) > Expect values are hard-coded in the verifications of TestRSGroupsBasics > ----------------------------------------------------------------------- > > Key: HBASE-22051 > URL: https://issues.apache.org/jira/browse/HBASE-22051 > Project: HBase > Issue Type: Improvement > Components: rsgroup, test > Reporter: Xiang Li > Assignee: Xiang Li > Priority: Minor > Attachments: HBASE-22051.master.000.patch > > > In TestRSGroupsBase, we have NUM_SLAVES_BASE = 4, which is used to launch the > mini cluster. But in some verifications of TestGroupsBasics, such as in > testBasicStartUp(), the expected value is hard-coded as 4, like: > {code:java} > public void testBasicStartUp() throws IOException { > ... > assertEquals(4, defaultInfo.getServers().size()); > .. > } > {code} > We could also some other places which have hard-coded verifications, as > follow: > {code:java} > public void testClearDeadServers() throws Exception { > ... > final RSGroupInfo newGroup = addGroup(getGroupName(name.getMethodName()), > 3); > ... > assertEquals(2, newGroupServers.size()); > {code} > and > {code:java} > public void testClearNotProcessedDeadServer() throws Exception { > ... > RSGroupInfo appInfo = addGroup("deadServerGroup", 1); > ... > assertEquals(1, notClearedServers.size()); > {code} -- This message was sent by Atlassian JIRA (v7.6.3#76005)