[ 
https://issues.apache.org/jira/browse/HBASE-22074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16799961#comment-16799961
 ] 

Duo Zhang commented on HBASE-22074:
-----------------------------------

OK, after HBASE-21895, the javac error is clear, it's just about order...

This is the result for the base branch.
{noformat}
[WARNING] 
/testptch/hbase/hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncRpcRetryingCaller.java:[125,69]
 [UnusedVariable] The parameter 'updateCachedLocation' is never read.
[WARNING] 
/testptch/hbase/hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncRpcRetryingCaller.java:[125,42]
 [UnusedVariable] The parameter 'error' is never read.
{noformat}

And this is the result for the patched branch
{noformat}
[WARNING] 
/testptch/hbase/hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncRpcRetryingCaller.java:[125,42]
 [UnusedVariable] The parameter 'error' is never read.
[WARNING] 
/testptch/hbase/hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncRpcRetryingCaller.java:[125,69]
 [UnusedVariable] The parameter 'updateCachedLocation' is never read.
{noformat}

So it will report a new one and a fixed one... Maybe we should sort before 
calling diff? [~busbey]. Thanks.

> Should use procedure store to persist the state in reportRegionStateTransition
> ------------------------------------------------------------------------------
>
>                 Key: HBASE-22074
>                 URL: https://issues.apache.org/jira/browse/HBASE-22074
>             Project: HBase
>          Issue Type: Bug
>          Components: amv2, proc-v2
>            Reporter: Duo Zhang
>            Assignee: Duo Zhang
>            Priority: Blocker
>             Fix For: 3.0.0, 2.2.0, 2.3.0
>
>         Attachments: HBASE-22074-v1.patch, HBASE-22074-v2.patch, 
> HBASE-22074-v3.patch, HBASE-22074-v3.patch, HBASE-22074.patch
>
>
> For now we will update the meta region directly. This may cause lots of 
> problems and after a bunch of fixes, we still can not solve the problem in 
> HBASE-22060.
> So maybe the approach itself is not a good choice, let's try another way to 
> see if it could work better.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to