[ https://issues.apache.org/jira/browse/HBASE-22057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16800799#comment-16800799 ]
Hadoop QA commented on HBASE-22057: ----------------------------------- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 18s{color} | {color:blue} Docker mode activated. {color} | || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m 0s{color} | {color:green} Patch does not have any anti-patterns. {color} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 1s{color} | {color:green} The patch does not contain any @author tags. {color} | | {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s{color} | {color:green} The patch appears to include 1 new or modified test files. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m 49s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 23s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 11s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m 6s{color} | {color:green} branch has no errors when building our shaded downstream artifacts. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m 27s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 11s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m 49s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 22s{color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} javac {color} | {color:red} 0m 22s{color} | {color:red} hbase-zookeeper generated 4 new + 46 unchanged - 4 fixed = 50 total (was 50) {color} | | {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 12s{color} | {color:red} hbase-zookeeper: The patch generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0) {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m 8s{color} | {color:green} patch has no errors when building our shaded downstream artifacts. {color} | | {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 7m 57s{color} | {color:green} Patch does not cause any errors with Hadoop 2.7.4 or 3.0.0. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m 35s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 11s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 46s{color} | {color:green} hbase-zookeeper in the patch passed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 7s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 27m 59s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:b002b0b | | JIRA Issue | HBASE-22057 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12963633/HBASE-22057.004.patch | | Optional Tests | dupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux ed4094f69996 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh | | git revision | master / 6de8a37b63 | | maven | version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z) | | Default Java | 1.8.0_181 | | findbugs | v3.1.11 | | javac | https://builds.apache.org/job/PreCommit-HBASE-Build/16530/artifact/patchprocess/diff-compile-javac-hbase-zookeeper.txt | | checkstyle | https://builds.apache.org/job/PreCommit-HBASE-Build/16530/artifact/patchprocess/diff-checkstyle-hbase-zookeeper.txt | | Test Results | https://builds.apache.org/job/PreCommit-HBASE-Build/16530/testReport/ | | Max. process+thread count | 291 (vs. ulimit of 10000) | | modules | C: hbase-zookeeper U: hbase-zookeeper | | Console output | https://builds.apache.org/job/PreCommit-HBASE-Build/16530/console | | Powered by | Apache Yetus 0.8.0 http://yetus.apache.org | This message was automatically generated. > Impose upper-bound on size of ZK ops sent in a single multi() > ------------------------------------------------------------- > > Key: HBASE-22057 > URL: https://issues.apache.org/jira/browse/HBASE-22057 > Project: HBase > Issue Type: Bug > Reporter: Josh Elser > Assignee: Josh Elser > Priority: Major > Fix For: 3.0.0, 1.6.0, 2.2.0 > > Attachments: HBASE-22057.001.patch, HBASE-22057.002.patch, > HBASE-22057.003.patch, HBASE-22057.004.patch > > > In {{ZKUtil#multiOrSequential}}, we accept a list of {{ZKUtilOp}}'s to pass > down to the {{ZooKeeper#multi(Iterable<Op>)}} method. > One problem with this approach is that we may generate a large list of ZNodes > to mutate in one batch which exceeds the allowable client package length, > specified by {{jute.maxbuffer}}. > This problem can manifest when we have a large number of WALs to replicate, > queued in ZooKeeper, from a disabled peer. When that peer is dropped, the RS > would submit deletes of those queued WALs. The RS will see ConnectionLoss for > the resulting {{multi()}} calls it tries to make, because we are sending too > large of a client message (because we're trying to delete too many WALs at > once). The result (at least in branch-1 ish versions) is that the RS aborts > after exceeding the ZK retries (as this operation will never succeed). > A simple fix would be to impose a maximum number of Ops to run in a single > batch inside ZKUtil, and split apart the caller-submitted batch into smaller > chunks. Before we make such a change, I do need to make sure that we don't > have any expectations on atomicity of the operations. I'm not sure what ZK > provides here -- for the above example, splitting up batches of deletes is > not an issue, but there could be issues with batches of creates where we only > apply some. -- This message was sent by Atlassian JIRA (v7.6.3#76005)