[ https://issues.apache.org/jira/browse/HBASE-5603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13233748#comment-13233748 ]
Jonathan Hsieh commented on HBASE-5603: --------------------------------------- There was recently a patch committed to the script which makes me think there is at least someone using this. Would it be best to do a quick "fix" for 0.92 and decide to remove for 0.94+ or from 0.96+? > rolling-restart.sh script hangs when attempting to detect expiration of > /hbase/master znode. > -------------------------------------------------------------------------------------------- > > Key: HBASE-5603 > URL: https://issues.apache.org/jira/browse/HBASE-5603 > Project: HBase > Issue Type: Bug > Components: zookeeper > Affects Versions: 0.92.0, 0.94.0, 0.96.0 > Reporter: Jonathan Hsieh > Priority: Blocker > > Due to bugfix ZOOKEEPER-1059 (ZK 3.4.0+), the rolling-restart.sh script will > hang when attempting to make sure the /hbase/master znode is deleted. > Here's the code > {code} > # make sure the master znode has been deleted before continuing > zparent=`$bin/hbase org.apache.hadoop.hbase.util.HBaseConfTool > zookeeper.znode.parent` > if [ "$zparent" == "null" ]; then zparent="/hbase"; fi > zmaster=`$bin/hbase org.apache.hadoop.hbase.util.HBaseConfTool > zookeeper.znode.master` > if [ "$zmaster" == "null" ]; then zmaster="master"; fi > zmaster=$zparent/$zmaster > echo -n "Waiting for Master ZNode ${zmaster} to expire" > while bin/hbase zkcli stat $zmaster >/dev/null 2>&1; do > echo -n "." > sleep 1 > done > echo #force a newline > {code} > Prior to ZOOKEEPER-1059, stat on a null znode would NPE and cause zkcli to > exit with retcode 1. Afterwards, the null is caught, zkcli will exit with 0 > in the case where the znode is present and in the case where it does not > exist. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira