[ 
https://issues.apache.org/jira/browse/HBASE-22106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16814635#comment-16814635
 ] 

Ankit Singhal edited comment on HBASE-22106 at 4/10/19 5:09 PM:
----------------------------------------------------------------

{quote}Should this go to all active branch-1 releases, Ankit? No need on 
branch-2 releases/master?
{quote}
It seems to be applicable on branch-1 only. As in branch-2 , we are simply 
ignoring any malformed coprocessor while loading.(Not sure if ignoring them 
without warning is a good idea)
 
 


was (Author: an...@apache.org):
bq. Should this go to all active branch-1 releases, Ankit? No need on branch-2 
releases/master?

It seems to be applicable on branch-1 only. As in branch-2 , we are simply 
ignoring any malformed coprocessor while loading.(Not sure if ignoring them is 
a good idea)
 
 

> Log cause of the failure when coprocessor specification parsing fails.
> ----------------------------------------------------------------------
>
>                 Key: HBASE-22106
>                 URL: https://issues.apache.org/jira/browse/HBASE-22106
>             Project: HBase
>          Issue Type: Bug
>          Components: logging
>    Affects Versions: 1.4.9
>            Reporter: Ankit Singhal
>            Assignee: Ankit Singhal
>            Priority: Minor
>             Fix For: 1.4.10, 1.3.4, 1.5.1
>
>         Attachments: HBASE-22106.branch-1.4.001.patch
>
>
>  {code}
> 2019-02-15 22:56:33,008 ERROR [RS_OPEN_REGION-n79:16020-16] 
> regionserver.RegionCoprocessorHost: Malformed table coprocessor 
> specification: key=coprocessor$2, spec: 
> |org.apache.phoenix.coprocessor.UngroupedAggregateRegionObserver|805306366|
> 2019-02-16 00:39:33,651 ERROR [RS_OPEN_REGION-n76:16020-14] 
> regionserver.RegionCoprocessorHost: Malformed table coprocessor 
> specification: key=coprocessor$1, spec: 
> |org.apache.phoenix.coprocessor.ScanRegionObserver|805306366|
> 2019-02-16 00:39:33,651 ERROR [RS_OPEN_REGION-n76:16020-19] 
> regionserver.RegionCoprocessorHost: Malformed table coprocessor 
> specification: key=coprocessor$1, spec: 
> |org.apache.phoenix.coprocessor.ScanRegionObserver|805306366|
>  {code}
> I checked the same coprocessor specification(logged in exception) with the 
> code and it is parsed successfully. And even after the restart , regionserver 
> also didn't complain about it.
> I think we should be logging the cause of the exception while parsing table 
> descriptor for the coprocessor for better debugging.
> https://github.com/apache/hbase/blob/branch-1.4/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RegionCoprocessorHost.java#L318



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to