[ 
https://issues.apache.org/jira/browse/HBASE-10761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16815927#comment-16815927
 ] 

Biju Nair edited comment on HBASE-10761 at 4/12/19 3:21 AM:
------------------------------------------------------------

Currently 
[SLB|https://github.com/apache/hbase/blob/baf3ae80f5588ee848176adefc9f56818458a387/hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/StochasticLoadBalancer.java#L275]
 has logic to check {{needBalance}} and not use the one from SimpleLoadBalancer 
which seems to satisfy this requirement. Can this be closed?


was (Author: gsbiju):
Currently 
[SLB|https://github.com/apache/hbase/blob/baf3ae80f5588ee848176adefc9f56818458a387/hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/StochasticLoadBalancer.java#L275]
 has logic to check {{needBalance}} which seems to satisfy this requirement. 
Can this be closed?

> StochasticLoadBalancer still uses SimpleLoadBalancer's needBalance logic
> ------------------------------------------------------------------------
>
>                 Key: HBASE-10761
>                 URL: https://issues.apache.org/jira/browse/HBASE-10761
>             Project: HBase
>          Issue Type: Bug
>          Components: Balancer
>    Affects Versions: 0.98.0
>            Reporter: Victor Xu
>            Priority: Major
>         Attachments: HBASE_10761.patch, HBASE_10761_v2.patch
>
>
> StochasticLoadBalancer has become the default balancer since 0.98.0. But its 
> balanceCluster method still uses the BaseLoadBalancer.needBalance() which is 
> originally designed for SimpleLoadBalancer. It's all based on the number of 
> regions on the regionservers.
> This can cause such a problem: when the cluster has some Hot Spot Region, the 
> balance process may not be triggered because the numbers of regions on the 
> RegionServers are averaged.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to