[
https://issues.apache.org/jira/browse/HBASE-22222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16816761#comment-16816761
]
stack edited comment on HBASE-22222 at 4/13/19 12:32 AM:
---------------------------------------------------------
Ok. Using same trick as for CanIgnoreReturnValue, the failure remains but now
it is because it can't find the unshaded Immutable at User API javadoc time:
{code}
[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-site-plugin:3.7.1:site (default-site) on project
hbase: Error generating maven-javadoc-plugin:3.0.1:aggregate report:
[ERROR] Exit code: 1 -
/Users/stack/checkouts/hbase.git/hbase-common/src/main/java/org/apache/hadoop/hbase/CellUtil.java:1034:
warning - Tag @link: can't find tagsIterator(Cell) in
org.apache.hadoop.hbase.CellUtil
[ERROR] javadoc: error - class file for
com.google.errorprone.annotations.Immutable not found
[ERROR]
{code}
I can make a new thirdparty RC but still need to deal w/ the above -- perhaps
adding errorprone dependency at java doc time? (The error prone we use is same
as that used by protobuf util).
Here is thirdparty change:
{code}
diff --git a/hbase-shaded-miscellaneous/pom.xml
b/hbase-shaded-miscellaneous/pom.xml
index 1e93600..ac8b9df 100644
--- a/hbase-shaded-miscellaneous/pom.xml
+++ b/hbase-shaded-miscellaneous/pom.xml
@@ -74,6 +74,7 @@
<shadedPattern>${rename.offset}.com.google</shadedPattern>
<excludes>
<exclude>com.google.errorprone.annotations.CanIgnoreReturnValue</exclude>
+
<exclude>com.google.errorprone.annotations.Immutable</exclude>
</excludes>
</relocation>
<relocation>
diff --git a/hbase-shaded-netty/pom.xml b/hbase-shaded-netty/pom.xml
index b9ac1d5..635032c 100644
--- a/hbase-shaded-netty/pom.xml
+++ b/hbase-shaded-netty/pom.xml
@@ -73,6 +73,7 @@
<shadedPattern>${rename.offset}.io.netty</shadedPattern>
<excludes>
<exclude>com.google.errorprone.annotations.CanIgnoreReturnValue</exclude>
+
<exclude>com.google.errorprone.annotations.Immutable</exclude>
</excludes>
</relocation>
</relocations>
diff --git a/hbase-shaded-protobuf/pom.xml b/hbase-shaded-protobuf/pom.xml
index e3b438a..e724208 100644
--- a/hbase-shaded-protobuf/pom.xml
+++ b/hbase-shaded-protobuf/pom.xml
@@ -160,6 +160,7 @@
<shadedPattern>${rename.offset}.com.google.protobuf</shadedPattern>
<excludes>
<exclude>com.google.errorprone.annotations.CanIgnoreReturnValue</exclude>
+
<exclude>com.google.errorprone.annotations.Immutable</exclude>
</excludes>
</relocation>
<!-- Our protos depend on the protos at this location.
@@ -170,6 +171,7 @@
<shadedPattern>${rename.offset}.google.protobuf</shadedPattern>
<excludes>
<exclude>com.google.errorprone.annotations.CanIgnoreReturnValue</exclude>
+
<exclude>com.google.errorprone.annotations.Immutable</exclude>
</excludes>
</relocation>
-->
{code}
was (Author: stack):
Ok. Using same trick as for CanIgnoreReturnValue, the failure remains but now
it is because it can't find the unshaded Immutable at User API javadoc time:
{code}
[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-site-plugin:3.7.1:site (default-site) on project
hbase: Error generating maven-javadoc-plugin:3.0.1:aggregate report:
[ERROR] Exit code: 1 -
/Users/stack/checkouts/hbase.git/hbase-common/src/main/java/org/apache/hadoop/hbase/CellUtil.java:1034:
warning - Tag @link: can't find tagsIterator(Cell) in
org.apache.hadoop.hbase.CellUtil
[ERROR] javadoc: error - class file for
com.google.errorprone.annotations.Immutable not found
[ERROR]
{code}
I can make a new thirdparty RC but still need to deal w/ the above -- perhaps
adding errorprone dependency at java doc time? (The error prone we use is same
as that used by protobuf util).
> Site build fails after hbase-thirdparty upgrade
> -----------------------------------------------
>
> Key: HBASE-22222
> URL: https://issues.apache.org/jira/browse/HBASE-22222
> Project: HBase
> Issue Type: Bug
> Components: website
> Affects Versions: 3.0.0, 2.2.0
> Reporter: Peter Somogyi
> Assignee: Peter Somogyi
> Priority: Critical
> Fix For: 3.0.0
>
>
> After hbase-thirdparty upgrade the hbase_generate_website job is failing in
> mvn site target on javadoc.
>
> {noformat}
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-site-plugin:3.7.1:site (default-site) on
> project hbase: Error generating maven-javadoc-plugin:3.0.1:aggregate report:
> [ERROR] Exit code: 1 -
> /home/jenkins/jenkins-slave/workspace/hbase_generate_website/hbase/hbase-common/src/main/java/org/apache/hadoop/hbase/CellUtil.java:1034:
> warning - Tag @link: can't find tagsIterator(Cell) in
> org.apache.hadoop.hbase.CellUtil
> [ERROR] javadoc: error - class file for
> org.apache.hbase.thirdparty.com.google.errorprone.annotations.Immutable not
> found{noformat}
> After reverting thirdparty upgrade locally the site build passed.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
