[
https://issues.apache.org/jira/browse/HBASE-8868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16816828#comment-16816828
]
stack commented on HBASE-8868:
------------------------------
Patch is beautiful. I didn't know how to expose short circuit reads. This does
that and more. The descriptions on the metrics could be beefed up I think.
What is 'totalBytesRead'? Is it from the fs? How does this differ from
'local'? Is that from local DN if HDFS? Should javadoc say 'may be zero'
especially if not hdfs? (This is a 'nit'!) Otherwise, patch is great. Lets get
it in.
> add metric to report client shortcircuit reads
> ----------------------------------------------
>
> Key: HBASE-8868
> URL: https://issues.apache.org/jira/browse/HBASE-8868
> Project: HBase
> Issue Type: Improvement
> Components: metrics, regionserver
> Affects Versions: 0.94.8, 0.95.1
> Reporter: Viral Bajaria
> Assignee: Wei-Chiu Chuang
> Priority: Minor
> Attachments: HBASE-8868.master.001.patch
>
>
> With the availability of shortcircuit reads, when the feature is enabled
> there is no metric which exposes how many times the regionserver was able to
> shortcircuit the read and not make a IPC to the datanode.
> It will be great to add the metric and expose it via Ganglia.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
