[ 
https://issues.apache.org/jira/browse/HBASE-21959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16820561#comment-16820561
 ] 

Andrew Purtell commented on HBASE-21959:
----------------------------------------

After a few suite runs it's looking better with the unit test from this commit 
removed. A bit early to call it yet, though
{quote}Should we call cleanupTestDir() before 'shutdownMiniCluster()' ? 
{quote}
No. Cluster has to shut down before cleanup will completely succeed, cluster 
may have open files, or do flushing or shutdown, or...

> CompactionTool should close the store it uses for compacting files, in order 
> to properly archive compacted files.
> -----------------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-21959
>                 URL: https://issues.apache.org/jira/browse/HBASE-21959
>             Project: HBase
>          Issue Type: Bug
>          Components: tooling
>            Reporter: Wellington Chevreuil
>            Assignee: Wellington Chevreuil
>            Priority: Major
>             Fix For: 3.0.0, 1.5.0, 1.4.10, 2.3.0
>
>         Attachments: HBASE-21959-branch-1-001.patch, 
> HBASE-21959-branch-1-002.patch, HBASE-21959-master-001.patch, 
> HBASE-21959-master-002.patch, HBASE-21959-master-003.patch
>
>
> While using CompactionTool to offload RSes, noticed compacted files were 
> never archived from original region dir, causing the space used by the region 
> to actually double. Going through its compaction related code on HStore, 
> which is used by CompactionTool for performing compactions, found out what 
> that compacted files archiving happens mainly while closing the HStore 
> instance. CompactionTool is never explicitly closing its HStore instance, so 
> adding a simple patch that properly close the store.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to