[ https://issues.apache.org/jira/browse/HBASE-5573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13235057#comment-13235057 ]
Hadoop QA commented on HBASE-5573: ---------------------------------- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12519310/5573.v6.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 12 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 4 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: org.apache.hadoop.hbase.io.hfile.TestForceCacheImportantBlocks Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1242//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1242//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1242//console This message is automatically generated. > Replace client ZooKeeper watchers by simple ZooKeeper reads > ----------------------------------------------------------- > > Key: HBASE-5573 > URL: https://issues.apache.org/jira/browse/HBASE-5573 > Project: HBase > Issue Type: Improvement > Components: client, zookeeper > Affects Versions: 0.96.0 > Reporter: nkeywal > Assignee: nkeywal > Priority: Minor > Attachments: 5573.v1.patch, 5573.v2.patch, 5573.v4.patch, > 5573.v6.patch > > > Some code in the package needs to read data in ZK. This could be done by a > simple read, but is actually implemented with a watcher. This holds ZK > resources. > Fixing this could also be an opportunity to remove the need for the client to > provide the master address and port. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira