[
https://issues.apache.org/jira/browse/HBASE-21957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16822925#comment-16822925
]
HBase QA commented on HBASE-21957:
----------------------------------
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
0s{color} | {color:blue} Docker mode activated. {color} |
| {color:red}-1{color} | {color:red} patch {color} | {color:red} 0m 6s{color}
| {color:red} HBASE-21957 does not apply to HBASE-21879. Rebase required? Wrong
Branch? See
https://yetus.apache.org/documentation/in-progress/precommit-patchnames for
help. {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | HBASE-21957 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12966609/HBASE-21957.HBASE-21879.v11.patch
|
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/134/console |
| Powered by | Apache Yetus 0.9.0 http://yetus.apache.org |
This message was automatically generated.
> Unify refCount of BucketEntry and refCount of hbase.nio.ByteBuff into one
> -------------------------------------------------------------------------
>
> Key: HBASE-21957
> URL: https://issues.apache.org/jira/browse/HBASE-21957
> Project: HBase
> Issue Type: Sub-task
> Reporter: Zheng Hu
> Assignee: Zheng Hu
> Priority: Major
> Attachments: HBASE-21957.HBASE-21879.v1.patch,
> HBASE-21957.HBASE-21879.v10.patch, HBASE-21957.HBASE-21879.v11.patch,
> HBASE-21957.HBASE-21879.v11.patch, HBASE-21957.HBASE-21879.v2.patch,
> HBASE-21957.HBASE-21879.v3.patch, HBASE-21957.HBASE-21879.v4.patch,
> HBASE-21957.HBASE-21879.v5.patch, HBASE-21957.HBASE-21879.v6.patch,
> HBASE-21957.HBASE-21879.v8.patch, HBASE-21957.HBASE-21879.v9.patch,
> HBASE-21957.HBASE-21879.v9.patch
>
>
> After HBASE-12295, we have block with MemoryType.SHARED or
> MemoryType.EXCLUSIVE, the block in offheap BucketCache will be shared, and
> have an reference count to track its life cycle. If no rpc reference to the
> shared block, then the block can be evicted.
> while after the HBASE-21916, we introduced an refcount for ByteBuff, then I
> think we can unify the two into one. tried to fix this when preparing patch
> for HBASE-21879, but seems can be different sub-task, and it won't affect the
> main logic of HBASE-21879, so create a seperate one.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
