Apache-HBase commented on issue #144: HBASE-22232 Removed deprecated methods in CompareFilter URL: https://github.com/apache/hbase/pull/144#issuecomment-485563780 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |:----:|----------:|--------:|:--------| | 0 | reexec | 24 | Docker mode activated. | ||| _ Prechecks _ | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 10 new or modified test files. | ||| _ master Compile Tests _ | | 0 | mvndep | 23 | Maven dependency ordering for branch | | +1 | mvninstall | 240 | master passed | | +1 | compile | 133 | master passed | | +1 | checkstyle | 156 | master passed | | +1 | shadedjars | 265 | branch has no errors when building our shaded downstream artifacts. | | +1 | findbugs | 389 | master passed | | +1 | javadoc | 101 | master passed | ||| _ Patch Compile Tests _ | | 0 | mvndep | 13 | Maven dependency ordering for patch | | +1 | mvninstall | 231 | the patch passed | | +1 | compile | 134 | the patch passed | | +1 | javac | 134 | the patch passed | | +1 | checkstyle | 33 | hbase-client: The patch generated 0 new + 186 unchanged - 52 fixed = 186 total (was 238) | | +1 | checkstyle | 66 | hbase-server: The patch generated 0 new + 90 unchanged - 9 fixed = 90 total (was 99) | | +1 | checkstyle | 28 | The patch passed checkstyle in hbase-thrift | | +1 | checkstyle | 16 | hbase-rest: The patch generated 0 new + 242 unchanged - 3 fixed = 242 total (was 245) | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 258 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 501 | Patch does not cause any errors with Hadoop 2.7.4 or 3.0.0. | | +1 | findbugs | 429 | the patch passed | | +1 | javadoc | 101 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 200 | hbase-client in the patch passed. | | +1 | unit | 8249 | hbase-server in the patch passed. | | +1 | unit | 223 | hbase-thrift in the patch passed. | | +1 | unit | 306 | hbase-rest in the patch passed. | | +1 | asflicense | 96 | The patch does not generate ASF License warnings. | | | | 12339 | | | Subsystem | Report/Notes | |----------:|:-------------| | Docker | Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-144/4/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/144 | | Optional Tests | dupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 786bab52670f 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /testptch/patchprocess/precommit/personality/provided.sh | | git revision | master / 2067b23c8c | | maven | version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z) | | Default Java | 1.8.0_181 | | findbugs | v3.1.11 | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-144/4/testReport/ | | Max. process+thread count | 5288 (vs. ulimit of 10000) | | modules | C: hbase-client hbase-server hbase-thrift hbase-rest U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-144/4/console | | Powered by | Apache Yetus 0.9.0 http://yetus.apache.org | This message was automatically generated.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services