[ 
https://issues.apache.org/jira/browse/HBASE-5469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13235241#comment-13235241
 ] 

Phabricator commented on HBASE-5469:
------------------------------------

tedyu has accepted the revision "[jira] [HBASE-5469] Add baseline compression 
efficiency to DataBlockEncodingTool".

  It would be nice to attach sample output from DataBlockEncodingTool to JIRA.

INLINE COMMENTS
  src/main/java/org/apache/hadoop/hbase/io/encoding/EncodedDataBlock.java:53 
Nice catch.
  src/main/java/org/apache/hadoop/hbase/io/encoding/EncodedDataBlock.java:150 
Nice.
  src/main/java/org/apache/hadoop/hbase/io/encoding/EncodedDataBlock.java:166 
This doesn't match the actual parameter name.
  src/main/java/org/apache/hadoop/hbase/io/encoding/EncodedDataBlock.java:183 
Where is cachedEncodedData invalidated ?

REVISION DETAIL
  https://reviews.facebook.net/D2409

BRANCH
  add_baseline_compression_efficiency_to_HBASE-5469_v5

                
> Add baseline compression efficiency to DataBlockEncodingTool
> ------------------------------------------------------------
>
>                 Key: HBASE-5469
>                 URL: https://issues.apache.org/jira/browse/HBASE-5469
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Mikhail Bautin
>            Assignee: Mikhail Bautin
>            Priority: Minor
>         Attachments: D2409.1.patch
>
>
> DataBlockEncodingTool currently does not provide baseline compression 
> efficiency, e.g. Hadoop compression codec applied to unencoded data. E.g. if 
> we are using LZO to compress blocks, we would like to have the following 
> columns in the report (possibly as percentages of raw data size).
> Baseline K+V in blockcache  |   Baseline K + V on disk  (LZO compressed)  | K 
> + V  DataBlockEncoded in block cache |   K + V DataBlockEncoded + 
> LZOCompressed (on disk)
> Background: we never store compressed blocks in cache, but we always store 
> encoded data blocks in cache if data block encoding is enabled for the column 
> family.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to