[ https://issues.apache.org/jira/browse/HBASE-22250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16825001#comment-16825001 ]
Hudson commented on HBASE-22250: -------------------------------- Results for branch master [build #957 on builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/957/]: (x) *{color:red}-1 overall{color}* ---- details (if available): (x) {color:red}-1 general checks{color} -- For more information [see general report|https://builds.apache.org/job/HBase%20Nightly/job/master/957//General_Nightly_Build_Report/] (x) {color:red}-1 jdk8 hadoop2 checks{color} -- For more information [see jdk8 (hadoop2) report|https://builds.apache.org/job/HBase%20Nightly/job/master/957//JDK8_Nightly_Build_Report_(Hadoop2)/] (x) {color:red}-1 jdk8 hadoop3 checks{color} -- For more information [see jdk8 (hadoop3) report|https://builds.apache.org/job/HBase%20Nightly/job/master/957//JDK8_Nightly_Build_Report_(Hadoop3)/] (/) {color:green}+1 source release artifact{color} -- See build output for details. (/) {color:green}+1 client integration test{color} > The same constants used in many places should be placed in constant classes > --------------------------------------------------------------------------- > > Key: HBASE-22250 > URL: https://issues.apache.org/jira/browse/HBASE-22250 > Project: HBase > Issue Type: Improvement > Components: Client, conf, regionserver > Affects Versions: 1.2.0, 2.0.0, 2.1.1, 2.1.4 > Reporter: lixiaobao > Assignee: lixiaobao > Priority: Minor > Fix For: 3.0.0, 2.3.0, 2.2.1 > > Attachments: HBASE-22250.patch > > > I think we should put these configurations in the HConstants class to avoid > the trouble of modifying a lot of places when we modify them later. > {code:java} > public static final String MASTER_KRB_PRINCIPAL = > "hbase.master.kerberos.principal"; > public static final String MASTER_KRB_KEYTAB_FILE = > "hbase.master.keytab.file"; > public static final String REGIONSERVER_KRB_PRINCIPAL = > "hbase.regionserver.kerberos.principal"; > public static final String REGIONSERVER_KRB_KEYTAB_FILE = > "hbase.regionserver.keytab.file";{code} -- This message was sent by Atlassian JIRA (v7.6.3#76005)