[
https://issues.apache.org/jira/browse/HBASE-5624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13236384#comment-13236384
]
Hadoop QA commented on HBASE-5624:
----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12519584/HBASE-5624.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified
tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
-1 findbugs. The patch appears to introduce 1 new Findbugs (version 1.3.9)
warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
-1 core tests. The patch failed these unit tests:
org.apache.hadoop.hbase.util.TestFSUtils
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/1273//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/1273//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/1273//console
This message is automatically generated.
> Aborting regionserver when splitting region, may cause daughter region not
> assigned by ServerShutdownHandler.
> -------------------------------------------------------------------------------------------------------------
>
> Key: HBASE-5624
> URL: https://issues.apache.org/jira/browse/HBASE-5624
> Project: HBase
> Issue Type: Bug
> Reporter: chunhui shen
> Assignee: chunhui shen
> Attachments: HBASE-5624.patch
>
>
> If one region is splitting when regionserver is stoping.
> The following code may executed in SplitTransaction#openDaughters.
> {code}
> // TODO: Is this check needed here?
> if (stopped || stopping) {
> // add 2nd daughter first (see HBASE-4335)
> MetaEditor.addDaughter(server.getCatalogTracker(),
> b.getRegionInfo(), null);
> MetaEditor.addDaughter(server.getCatalogTracker(),
> a.getRegionInfo(), null);
> LOG.info("Not opening daughters " +
> b.getRegionInfo().getRegionNameAsString() +
> " and " +
> a.getRegionInfo().getRegionNameAsString() +
> " because stopping=" + stopping + ", stopped=" + stopped);
> }
> {code}
> So, for the two daughter regions, their location are both null in .META.
> When ServerShutdownHandler process the dead server, it will not assign these
> two daughter regions since their location(info:server) are null in .META. by
> MetaReader.getServerUserRegions().
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
