[
https://issues.apache.org/jira/browse/HBASE-22411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16848716#comment-16848716
]
Xiaolin Ha commented on HBASE-22411:
------------------------------------
Used Optional instead of null check, and has replied on the review board.
[~zghaobac]
----This method name is moveRegionsToServers. But the servers may be null? It
is weird...
I think 'to server' is confusing here. Because in rsgroup moving region
oprerations, target server is always null.
And in this method, the server set is part of the target group servers.
Actually regions will be moved to the target group servers, not only these
servers.
----The targetGroup may be null in old implmenation?
'targetGroup' is a passed in parameter, and has checked if it is null in front
codes.
I think 'targetGroup' won't be null here.
> Refactor codes of moving reigons in RSGroup
> -------------------------------------------
>
> Key: HBASE-22411
> URL: https://issues.apache.org/jira/browse/HBASE-22411
> Project: HBase
> Issue Type: Improvement
> Components: rsgroup
> Affects Versions: 2.2.0
> Reporter: Xiaolin Ha
> Assignee: Xiaolin Ha
> Priority: Major
> Attachments: HBASE-22411.branch-2.2.001.patch,
> HBASE-22411.master.001.patch, HBASE-22411.master.002.patch,
> HBASE-22411.master.003.patch, HBASE-22411.master.004.patch,
> HBASE-22411.master.005.patch, HBASE-22411.master.006.patch,
> HBASE-22411.master.007.patch, HBASE-22411.master.007.patch,
> HBASE-22411.master.007.patch, HBASE-22411.master.007.patch,
> HBASE-22411.master.008.patch, HBASE-22411.master.009.patch,
> HBASE-22411.master.010.patch, HBASE-22411.master.011.patch,
> HBASE-22411.master.012.patch
>
>
> Essentially RSGroup managed regions. Organizing tables or servers' RSGroups
> is to move relevant regions. Codes of moving regions can be refactored.
> So that some problems caused by moving regions can be fixed elegantly.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
