[
https://issues.apache.org/jira/browse/HBASE-22469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16850034#comment-16850034
]
Josh Elser commented on HBASE-22469:
------------------------------------
Actually, Artem, you changed too much.
{code:java}
@@ -317,7 +317,7 @@ AssignmentManager assignmentManager =
master.getAssignmentManager();
<tr>
<td>Hadoop Source Checksum</td>
<td><% org.apache.hadoop.util.VersionInfo.getSrcChecksum()
%></td>
- <td>Hadoop source MD5 checksum</td>
+ <td>Hadoop source SHA512 checksum</td>
</tr>
<tr>
<td>ZooKeeper Client Version</td>
{code}
You're modifying the table-cell for the Hadoop source checksum. The only change
you made here was to the HBase source checksum. The Hadoop checksum is still an
MD5.
Otherwise, this is fine. I'll just fix this on commit to branch-2 and master.
> replace md5 checksum in saveVersion script with sha512 for hbase version
> information
> ------------------------------------------------------------------------------------
>
> Key: HBASE-22469
> URL: https://issues.apache.org/jira/browse/HBASE-22469
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 3.0.0
> Environment: {code:java}
> Apache Maven 3.6.1 (d66c9c0b3152b2e69ee9bac180bb8fcc8e6af555;
> 2019-04-04T15:00:29-04:00)
> Maven home: /opt/apache-maven-3.6.1
> Java version: 1.8.0_172, vendor: Oracle Corporation, runtime:
> /Library/Java/JavaVirtualMachines/jdk1.8.0_172.jdk/Contents/Home/jre
> Default locale: en_US, platform encoding: UTF-8
> OS name: "mac os x", version: "10.13.6", arch: "x86_64", family: "mac"{code}
> Reporter: Artem Ervits
> Assignee: Artem Ervits
> Priority: Minor
> Attachments: HBASE-22469.v01.patch, HBASE-22469.v02.patch
>
>
> noticed that hbase version always prints out an md5 for source but since we
> long retired md5 from the releases, it makes sense to replace hbase version
> information as well. I also noticed that revision doesn't always show, case
> in point HBase 2.2.0 RC4 vote, revision=Unknown. In my tests, revision only
> appears if the compiled code was cloned from git and not a release candidate
> download file. In that sense, release candidates should be checked out rather
> than downloaded. This Jira only addresses replacement of the md5 sum.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
