Apache-HBase commented on issue #276: HBASE-22508 Address findbugs/spotbugs complaints (branch-1.4) URL: https://github.com/apache/hbase/pull/276#issuecomment-497560125 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |:----:|----------:|--------:|:--------| | 0 | reexec | 1090 | Docker mode activated. | ||| _ Prechecks _ | | 0 | findbugs | 0 | Findbugs executables are not available. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | -0 | test4tests | 0 | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ branch-1.4 Compile Tests _ | | 0 | mvndep | 13 | Maven dependency ordering for branch | | +1 | mvninstall | 121 | branch-1.4 passed | | +1 | compile | 65 | branch-1.4 passed with JDK v1.8.0_212 | | +1 | compile | 77 | branch-1.4 passed with JDK v1.7.0_222 | | +1 | checkstyle | 125 | branch-1.4 passed | | +1 | shadedjars | 166 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 57 | branch-1.4 passed with JDK v1.8.0_212 | | +1 | javadoc | 74 | branch-1.4 passed with JDK v1.7.0_222 | ||| _ Patch Compile Tests _ | | 0 | mvndep | 12 | Maven dependency ordering for patch | | +1 | mvninstall | 99 | the patch passed | | +1 | compile | 68 | the patch passed with JDK v1.8.0_212 | | +1 | javac | 68 | the patch passed | | +1 | compile | 78 | the patch passed with JDK v1.7.0_222 | | +1 | javac | 78 | the patch passed | | -1 | checkstyle | 90 | hbase-server: The patch generated 3 new + 365 unchanged - 6 fixed = 368 total (was 371) | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 166 | patch has no errors when building our shaded downstream artifacts. | | -1 | hadoopcheck | 57 | The patch causes 26 errors with Hadoop v2.4.1. | | -1 | hadoopcheck | 115 | The patch causes 26 errors with Hadoop v2.5.2. | | -1 | hadoopcheck | 181 | The patch causes 16 errors with Hadoop v2.6.5. | | +1 | javadoc | 58 | the patch passed with JDK v1.8.0_212 | | +1 | javadoc | 74 | the patch passed with JDK v1.7.0_222 | ||| _ Other Tests _ | | +1 | unit | 133 | hbase-common in the patch passed. | | +1 | unit | 31 | hbase-hadoop2-compat in the patch passed. | | -1 | unit | 7964 | hbase-server in the patch failed. | | +1 | asflicense | 59 | The patch does not generate ASF License warnings. | | | | 11063 | | | Reason | Tests | |-------:|:------| | Failed junit tests | hadoop.hbase.regionserver.TestScannerHeartbeatMessages | | | hadoop.hbase.coprocessor.TestMetaTableMetrics | | Subsystem | Report/Notes | |----------:|:-------------| | Docker | Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-276/1/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/276 | | Optional Tests | dupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 188619220e0d 4.4.0-137-generic #163~14.04.1-Ubuntu SMP Mon Sep 24 17:14:57 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /testptch/patchprocess/precommit/personality/provided.sh | | git revision | branch-1.4 / a4ac174 | | maven | version: Apache Maven 3.0.5 | | Default Java | 1.7.0_222 | | Multi-JDK versions | /usr/lib/jvm/java-8-openjdk-amd64:1.8.0_212 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_222 | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-276/1/artifact/out/diff-checkstyle-hbase-server.txt | | hadoopcheck | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-276/1/artifact/out/patch-javac-2.4.1.txt | | hadoopcheck | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-276/1/artifact/out/patch-javac-2.5.2.txt | | hadoopcheck | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-276/1/artifact/out/patch-javac-2.6.5.txt | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-276/1/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-276/1/testReport/ | | Max. process+thread count | 4021 (vs. ulimit of 10000) | | modules | C: hbase-common hbase-hadoop2-compat hbase-server U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-276/1/console | | Powered by | Apache Yetus 0.9.0 http://yetus.apache.org | This message was automatically generated.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
